[ZEPPELIN-2190] Support custom web development port #2113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will test and give you feedback soon. |
1ambda
reviewed
Mar 9, 2017
zeppelin-web/webpack.config.js
Outdated
| pattern: /WEB_PORT/ig, | ||
| replacement: function (match, p1, offset, string) { | ||
| return webPort; | ||
| } |
zeppelin-web/webpack.config.js
Outdated
| config.plugins.push(new InsertLiveReloadPlugin()) | ||
| config.plugins.push( | ||
| new InsertLiveReloadPlugin(), | ||
| // string replace plugin instance |
There was a problem hiding this comment.
MINOR: i think we can remove this comment line.
LINE 285
| @@ -24,7 +24,7 @@ function baseUrlSrv() { | |||
| } | |||
| } | |||
| //Exception for when running locally via grunt | |||
| if (port === 9000) { | |||
| if (port === process.env.WEB_PORT) { | |||
There was a problem hiding this comment.
We can remove if statement by modifying this like
var serverPort = process.env.SERVER_PORT || 8080;
var webPort = process.env.WEB_PORT || 9000;
There was a problem hiding this comment.
Oops. I wrote comments in different file. i meant webpack.config.js
There was a problem hiding this comment.
Sorry for my late response and I clearly understood your mentions!
Thanks @1ambda!
|
@1ambda Thanks for kind review! Let me update this soon! |
|
ping @soralee |
|
@1ambda Hi, I just updated as your comments. |
|
LGTM |
|
LGTM and merge to master if no further discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR is for support flexible port for custom
web application developmentand update the structure of README.md document for the support variable.What type of PR is it?
[ Improvement | Documentation (README.md) ]
What is the Jira issue?
How should this be tested?
mvn clean package -DskipTests -pl 'zeppelin-web'WEB_PORTvariable port underzeppelin-webfolderWEB_PORT=9999 yarn run devlocalhost:9999on web browserScreenshots (if appropriate)
[after]
Questions:
zeppelin-web