Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [Discuss] Make use of all grouped data to draw pie chart #2128

Closed
wants to merge 1 commit into from
Closed

[WIP] [Discuss] Make use of all grouped data to draw pie chart #2128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 19 additions & 11 deletions zeppelin-web/src/app/visualization/builtins/visualization-piechart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default class PiechartVisualization extends Nvd3ChartVisualization {
};

render(pivot) {
var d3Data = this.d3DataFromPivot(
const d3Data = this.d3DataFromPivot(
pivot.schema,
pivot.rows,
pivot.keys,
Expand All @@ -42,17 +42,25 @@ export default class PiechartVisualization extends Nvd3ChartVisualization {
true,
false,
false);
var d = d3Data.d3g;
var d3g = [];
if (d.length > 0) {
for (var i = 0; i < d[0].values.length ; i++) {
var e = d[0].values[i];
d3g.push({
label: e.x,
value: e.y
});
}
const d = d3Data.d3g;

let generateLabel;
// data is grouped
if (pivot.groups && pivot.groups.length > 0) {
generateLabel = (suffix, prefix) => `${prefix}.${suffix}`;
} else { // data isn't grouped
generateLabel = suffix => suffix;
}

let d3g = d.map(group => {
return group.values.map(row => ({
label: generateLabel(row.x, group.key),
value: row.y
}));
});
// the map function returns d3g as a nested array
// [].concat flattens it, http://stackoverflow.com/a/10865042/5154397
d3g = [].concat.apply([], d3g);
super.render({d3g: d3g});
};

Expand Down