[ZEPPELIN-2253] Piechart won't render when column selected as 'key' is changed #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes ZEPPELIN-2253 * When pie chart's key(domain) is changed, this error is logged: 'Uncaught TypeError: arcs[idx] is not a function at pie.js:358' * Even if we change key and values, chart remains broken * Fix: set this.chart to null, which inturn makes this.render to intialize a new chart constructor
|
A video showing the bug is uploaded at JIRA, cannot seem to upload the video here, the webm format isn't supported |
|
Tested and LGTM. Merge to master and branch-0.7 if no further comments. |
asfgit
pushed a commit
that referenced
this pull request
Mar 15, 2017
…s changed ### What is this PR for? * Fixes issue with pie chart rendering, if user changes pie chart's domain * When pie chart's key(domain) is changed, this error is logged: 'Uncaught TypeError: arcs[idx] is not a function at pie.js:358' * Even if user changes the key and values again, chart remains broken * Fix: set this.chart to null, which makes render function to initialize new pie chart constructor ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-533](https://issues.apache.org/jira/browse/ZEPPELIN-2253) ### How should this be tested? * Create a new pie chart using built in visualization * Remove column selected as 'key' * Add a new column as 'key' * Chart is rendered perfectly ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: ess_ess <sravans2011@gmail.com> Closes #2132 from sravan-s/ZEPPELIN-2253 and squashes the following commits: 310aecf [ess_ess] Initialize chart to null inside 'render()' (cherry picked from commit f2c865a) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
'Uncaught TypeError: arcs[idx] is not a function at pie.js:358'
pie chart constructor
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Questions: