Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2135

dlukyanov · 2017-03-14T20:09:51Z

What is this PR for?

Groovy Interpreter

What type of PR is it?

Feature

Todos

[ Tests ] - Task
[ Documentation ] - Task

What is the Jira issue?

[ZEPPELIN-2176]

How should this be tested?

Follow the groovy interpreter documentation samples

Questions:

Does the licenses files need update? YES
Is there breaking changes for older versions? NO
Does this needs documentation? YES

dlukyanov · 2017-03-14T22:09:10Z

@Leemoonsoo, I moved the repo under the user, used the latest master, now i have another error:

++ grep -e '"ref":' -e '"sha":'
++ tr '\n' ' '
+ COMMIT=
+ sleep 30
+ python ./travis_check.py dlukyanov
Traceback (most recent call last):
  File "./travis_check.py", line 36, in <module>
    commit = sys.argv[2]
IndexError: list index out of range
Build step 'Execute shell' marked build as failure
Putting comment on the pull request
Finished: FAILURE

Leemoonsoo · 2017-03-14T23:00:42Z

Jenkins build script didn't handle well when source branch name of pullrequest is master.
I just updated the jenkins build script to handle the name master.
@dlukyanov Could you trigger jenkins again (close/open pr) and see if it checks correctly?

dlukyanov · 2017-03-15T05:26:04Z

@Leemoonsoo, now I see status from travis )
And going to solve strange build errors...
Thanks!

Leemoonsoo · 2017-03-15T06:02:14Z

The error

[ERROR] error An unexpected error occurred: "https://registry.yarnpkg.com/binary-extensions/-/binary-extensions-1.8.0.tgz: Request failed \"502 Bad Gateway\"".
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:yarn (yarn install) on project zeppelin-web: Failed to run task: 'yarn install --no-lockfile' failed. (error code 1) -> [Help 1]
[ERROR]

looks like temporary network problem. You can always restart the failed Job and see if it passing.

… HTTP.groovy to resources to simplify build, add default z-properties

dlukyanov · 2017-03-19T11:04:46Z

@Leemoonsoo , is it possible to restart jenkins checks after travis succeed?
I've never got travis success without restarting travis jobs manually.
https://travis-ci.org/dlukyanov/zeppelin/builds

dlukyanov · 2017-03-21T08:23:06Z

Hello All, Asking for help with Jenkins:
Travis succeed: https://travis-ci.org/dlukyanov/zeppelin
But jenkins failed: https://builds.apache.org/job/zeppelin-pull-request/604/console

Build https://travis-ci.org/dlukyanov/zeppelin/builds/213281815
[1] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281816
[2] Not completed   https://travis-ci.org/dlukyanov/zeppelin/jobs/213281817
[3] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281818
[4] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281819
[5] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281820
[6] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281821
[7] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281822
[8] OK              https://travis-ci.org/dlukyanov/zeppelin/jobs/213281823
1 job(s) failed, 0 job(s) running/pending
+ RET_CODE=1
+ '[' 1 -eq 2 ']'
+ '[' 1 -eq 2 ']'
+ exit 1

Leemoonsoo · 2017-03-21T18:03:18Z

Looks like second test matrix succeeded after the manual restart.
In this case, you also need to trigger Jenkins again to check latest build status.
Simply close and reopen this PR will do that.

Leemoonsoo · 2017-03-23T19:09:51Z

I tested last commit and it works well.

However the variable can't be read from the other paragraph.

This behavior is different from other interpreters, like spark (scala), python, r.
Is it intended?

Also, can we place document under /docs/interpreter/ instead of /groovy/, so website can show groovy documentation?

dlukyanov · 2017-03-24T12:01:31Z

@Leemoonsoo Interesting) I did not knew that... i'll take a look how it's implemented...
With doc - i'll move it

- implement shared script variables - move docs - implement run methods

dlukyanov · 2017-03-25T22:26:58Z

@Leemoonsoo, Just committed changes.
Doc moved.
About shared vars - it will be a little different from scala/spark.
If you use groovy script variable (undeclared or annotated) it will behave like you mentioned

a="Hello world"
//or
@groovy.transform.Field String aa = "Hello world"
//or
g.put('aaa',"Hello world")

The usual declared variables - has local visibility.

Leemoonsoo · 2017-03-26T19:35:59Z

@dlukyanov Thanks for the update and explanation on behavior.

Inside of docs directory, groovy.md will need some header to be compiled with Jekyll. For example, spark.md

---
layout: page
title: "Apache Spark Interpreter for Apache Zeppelin"
description: "Apache Spark is a fast and general-purpose cluster computing system. It provides high-level APIs in Java, Scala, Python and R, and an optimized engine that supports general execution engine."
group: interpreter
---
<!--
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
{% include JB/setup %}

Menu in docs also need link to groovy. https://github.com/apache/zeppelin/blob/master/docs/_includes/themes/zeppelin/_navigation.html#L56

.travis.yml is updated since this branch is created. And we need add !groovy in this line. Could you handle it?

- Inside of docs directory, groovy.md will need some header to be compiled with Jekyll - Menu in docs also need link to groovy - .travis.yml we need add !groovy

dlukyanov · 2017-03-27T19:42:21Z

@Leemoonsoo , done. waiting for travis.

Leemoonsoo · 2017-03-27T21:07:17Z

Thanks @dlukyanov for the contribution.

LGTM!

Leemoonsoo · 2017-03-28T21:44:23Z

Merge to master if no further comments.

AhyoungRyu

@dlukyanov Thanks for great contribution and sorry for my late blocking. I left some minor comment about docs. BTW why did you added README.txt & README.md both?
And generally, Zeppelin follows Google Java code style#2-block-indentation. Can this be addressed as well before merge? Probably this looks not important but other ppl who want to contribute to Zeppelin can refer your PR(e.g. code style/ license handling/ docs etc etc..) in the future :)

AhyoungRyu · 2017-03-29T02:44:40Z

docs/_includes/themes/zeppelin/_navigation.html

@@ -78,6 +78,7 @@
                <li><a href="{{BASE_PATH}}/interpreter/scio.html">Scio</a></li>
                <li><a href="{{BASE_PATH}}/interpreter/shell.html">Shell</a></li>
                <li><a href="{{BASE_PATH}}/interpreter/spark.html">Spark</a></li>
+                <li><a href="{{BASE_PATH}}/interpreter/groovy.html">Groovy</a></li>


Can we put Groovy below Geode? It should be in alphabetical order.

AhyoungRyu · 2017-03-29T02:52:21Z

docs/interpreter/groovy.md

+
+* `groovy.xml.MarkupBuilder g.html()`
+
+Starts or continues rendering of `%angular` to output and returns [groovy.xml.MarkupBuilder](https://www.google.com/search?q=groovy.xml.MarkupBuilder)


How about this link http://groovy-lang.org/processing-xml.html#_markupbuilder instead of google search result ?

- Zeppelin follows Google Java code - interpreter alphabetical order in _navigation.html - direct link to MarkupBuilder in groovy help

dlukyanov · 2017-03-29T19:21:32Z

@AhyoungRyu, changes committed,waiting for travis...

From travis-ci.org:
We stopped accepting new builds because of an issue with our logs DB.
Sorry for the inconvenience. You can follow the updates here. Thank you for your understanding.

AhyoungRyu · 2017-03-30T03:42:09Z

groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java

@@ -55,159 +55,172 @@

 /**
 * Groovy interpreter for Zeppelin.
+ * @author dlukyanov@ukr.net / dmitry lukyanov


code autoformat.. but it's not allowed to keep the created by ? any footprint? )))

@dlukyanov I see. Yeah so sadly Zeppelin doesn't encourage the footprint 😭 (see here: d64920d)

AhyoungRyu · 2017-03-30T03:42:15Z

groovy/src/main/java/org/apache/zeppelin/groovy/GObject.java

@@ -41,308 +43,328 @@

 /**
 * Groovy interpreter for Zeppelin.
+ * @author dlukyanov@ukr.net / dmitry lukyanov


@dlukyanov Zeppelin generally don't write author name in the source code. Even if it does, all ppl still can track and see what you contribute to Zeppelin :)

AhyoungRyu · 2017-03-30T03:43:21Z

groovy/src/main/java/org/apache/zeppelin/groovy/GroovyInterpreter.java

+
+      bindings.clear();
+      InterpreterResult result = new InterpreterResult(Code.SUCCESS, out.toString());
+      //log.info("RESULT: "+result);


Could you remove this commented log.info if it's not necessary?

AhyoungRyu · 2017-03-30T03:46:46Z

Thanks for addressing my comments! I left some minor comments again about "author name" in the source code and removing unnecessary log.info. Except these two things, LGTM 👍

- remove @author - remove commented code

dlukyanov · 2017-03-31T05:16:20Z

@Leemoonsoo , @AhyoungRyu , any other comments?

AhyoungRyu · 2017-03-31T05:34:09Z

Looks good to me :)

AhyoungRyu · 2017-04-03T05:56:20Z

Merge to master if no further comments.

groovy interpreter

fa779ea

dlukyanov mentioned this pull request Mar 14, 2017

Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2068

Closed

Update README.md

db4c35b

retry

addf167

dlukyanov added 4 commits March 17, 2017 09:40

retry

aa427cd

ZEPPELIN-2176 groovy interpreter, fix unchecked, add to configs, move…

5fa26e0

… HTTP.groovy to resources to simplify build, add default z-properties

ZEPPELIN-2176 groovy interpreter, fix unchecked, add to configs, move…

2646fa8

… HTTP.groovy to resources to simplify build, add default z-properties

retry

0d7732a

dlukyanov changed the title ~~[WIP] Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176]~~ Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] Mar 21, 2017

retry

b34b42a

retry

dd388b3

ZEPPELIN-2176 apache#2135 (comment)

41a1702

- implement shared script variables - move docs - implement run methods

dm and others added 3 commits March 27, 2017 22:08

Merge branch 'master' of https://github.com/apache/zeppelin

4abf649

ZEPPELIN-2176 apache#2135 (comment)

a5b37a1

- Inside of docs directory, groovy.md will need some header to be compiled with Jekyll - Menu in docs also need link to groovy - .travis.yml we need add !groovy

Update groovy.md

ca8bea6

retry

fe08159

AhyoungRyu reviewed Mar 29, 2017

View reviewed changes

ZEPPELIN-2176 comments from @AhyoungRyu

3dd53e2

- Zeppelin follows Google Java code - interpreter alphabetical order in _navigation.html - direct link to MarkupBuilder in groovy help

dlukyanov added 2 commits March 29, 2017 22:45

deprecated

ca65947

retry

89c3ed5

AhyoungRyu reviewed Mar 30, 2017

View reviewed changes

ZEPPELIN-2176 comments from @AhyoungRyu

faf213f

- remove @author - remove commented code

asfgit closed this in 53a28a3 Apr 4, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2135

Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2135

dlukyanov commented Mar 14, 2017

dlukyanov commented Mar 14, 2017

Leemoonsoo commented Mar 14, 2017

dlukyanov commented Mar 15, 2017

Leemoonsoo commented Mar 15, 2017

dlukyanov commented Mar 19, 2017

dlukyanov commented Mar 21, 2017

Leemoonsoo commented Mar 21, 2017

Leemoonsoo commented Mar 23, 2017

dlukyanov commented Mar 24, 2017

dlukyanov commented Mar 25, 2017 •

edited

Leemoonsoo commented Mar 26, 2017

dlukyanov commented Mar 27, 2017

Leemoonsoo commented Mar 27, 2017

Leemoonsoo commented Mar 28, 2017

AhyoungRyu left a comment •

edited

AhyoungRyu Mar 29, 2017

AhyoungRyu Mar 29, 2017

dlukyanov commented Mar 29, 2017 •

edited

AhyoungRyu Mar 30, 2017

dlukyanov Mar 30, 2017

AhyoungRyu Mar 30, 2017

AhyoungRyu Mar 30, 2017

AhyoungRyu Mar 30, 2017

AhyoungRyu commented Mar 30, 2017

dlukyanov commented Mar 31, 2017

AhyoungRyu commented Mar 31, 2017

AhyoungRyu commented Apr 3, 2017


		* `groovy.xml.MarkupBuilder g.html()`

		Starts or continues rendering of `%angular` to output and returns [groovy.xml.MarkupBuilder](https://www.google.com/search?q=groovy.xml.MarkupBuilder)

Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2135

Groovy Interpreter for Apazhe Zeppelin [ZEPPELIN-2176] #2135

Conversation

dlukyanov commented Mar 14, 2017

What is this PR for?

What type of PR is it?

Todos

What is the Jira issue?

How should this be tested?

Questions:

dlukyanov commented Mar 14, 2017

Leemoonsoo commented Mar 14, 2017

dlukyanov commented Mar 15, 2017

Leemoonsoo commented Mar 15, 2017

dlukyanov commented Mar 19, 2017

dlukyanov commented Mar 21, 2017

Leemoonsoo commented Mar 21, 2017

Leemoonsoo commented Mar 23, 2017

dlukyanov commented Mar 24, 2017

dlukyanov commented Mar 25, 2017 • edited

Leemoonsoo commented Mar 26, 2017

dlukyanov commented Mar 27, 2017

Leemoonsoo commented Mar 27, 2017

Leemoonsoo commented Mar 28, 2017

AhyoungRyu left a comment • edited

Choose a reason for hiding this comment

AhyoungRyu Mar 29, 2017

Choose a reason for hiding this comment

AhyoungRyu Mar 29, 2017

Choose a reason for hiding this comment

dlukyanov commented Mar 29, 2017 • edited

AhyoungRyu Mar 30, 2017

Choose a reason for hiding this comment

dlukyanov Mar 30, 2017

Choose a reason for hiding this comment

AhyoungRyu Mar 30, 2017

Choose a reason for hiding this comment

AhyoungRyu Mar 30, 2017

Choose a reason for hiding this comment

AhyoungRyu Mar 30, 2017

Choose a reason for hiding this comment

AhyoungRyu commented Mar 30, 2017

dlukyanov commented Mar 31, 2017

AhyoungRyu commented Mar 31, 2017

AhyoungRyu commented Apr 3, 2017

dlukyanov commented Mar 25, 2017 •

edited

AhyoungRyu left a comment •

edited

dlukyanov commented Mar 29, 2017 •

edited