[ZEPPELIN-2124] Missing dependencies array in interpreter.json after upgrade from 0.6.2 to 0.7.0 #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
approved these changes
Mar 16, 2017
|
That's very simple :-) |
jongyoul
approved these changes
Mar 16, 2017
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2017
…upgrade from 0.6.2 to 0.7.0 ### What is this PR for? If there is no `dependencies` field specified in `interpreter.json`, front-end throws error because it tries to push new element to undefined variable. This PR fixes this issue by setting initial value of `dependencies` to empty array. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-2124](https://issues.apache.org/jira/browse/ZEPPELIN-2124) ### How should this be tested? Remove `dependencies` field from `conf/interpreter.json` and try to add new dependencies in http://localhost:8080/#/interpreter page. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Mina Lee <minalee@apache.org> Closes #2142 from minahlee/ZEPPELIN-2124 and squashes the following commits: 01b27eb [Mina Lee] Assign init value for dependencies field (cherry picked from commit f9a8a6f) Signed-off-by: Jongyoul Lee <jongyoul@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
If there is no
dependenciesfield specified ininterpreter.json, front-end throws error because it tries to push new element to undefined variable. This PR fixes this issue by setting initial value ofdependenciesto empty array.What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-2124
How should this be tested?
Remove
dependenciesfield fromconf/interpreter.jsonand try to add new dependencies in http://localhost:8080/#/interpreter page.Questions: