Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-1889] Fill missing values to grouped data #2160

Closed
wants to merge 2 commits into from

Conversation

sravan-s
Copy link
Contributor

@sravan-s sravan-s commented Mar 19, 2017

What is this PR for?

Fix for multiple group in multi-bar chart

If any value is missing under any domain key in stacked multi-bar chart,
it won't get rendered. Fix this bug by adding fillMissingValues flag in
d3DataFromPivot()

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

  • Create a paragraph with tabular output
  • Add multiple groups to input
  • Render the stacked multi bar chart
  • Chart should be rendered properly

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@sravan-s
Copy link
Contributor Author

Are there any problems in CI?

If any value is missing under any domain key in
stacked multibar chart, chart won't get rendered
Fix this bug by adding fillMissingValues flag in
d3DataFromPivot()
@Leemoonsoo
Copy link
Member

I checked Jenkins log for last commit 368a50e. And looks like Jenkins build script somehow confused with 'merge' and handling it not very well. :-(

@sravan-s
Copy link
Contributor Author

sravan-s commented Mar 20, 2017

Sorry, it's my mistake, I did a pull instead of rebase
I'll reopen this

@sravan-s sravan-s closed this Mar 20, 2017
@sravan-s sravan-s reopened this Mar 20, 2017
@sravan-s sravan-s closed this Mar 20, 2017
@sravan-s sravan-s reopened this Mar 20, 2017
@sravan-s sravan-s closed this Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants