[ZEPPELIN-2318] Fix proxy configuration for http client of zeppelinhub storage layer #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixcheung
reviewed
Mar 29, 2017
| if (proxyClient != null) { | ||
| body = proxyClient.sendToZeppelinHub(request, withResponse); | ||
| } else { | ||
| LOG.error("Proxy client request was submitted while not correctly initialized"); |
There was a problem hiding this comment.
this should be a warning perhaps? since we ignore it anyway
| try { | ||
| uri = new URI(proxyHostString); | ||
| } catch (URISyntaxException e) { | ||
| LOG.error("Proxy uri doesn't follow correct syntax", e); |
|
@felixcheung right |
felixcheung
approved these changes
Apr 1, 2017
|
merge into master and branch-0.7 if no further comments |
1 task
asfgit
pushed a commit
that referenced
this pull request
Apr 20, 2017
…f zeppelinhub storage layer ### What is this PR for? this is to resolve this issue for `branch-0.7` since original PR #2198 had conflicts with the branch. for more details check the original pr ### What type of PR is it? Bug Fix | Improvement ### Todos * [x] - Task ### What is the Jira issue? [ZEPPELIN-2318](https://issues.apache.org/jira/browse/ZEPPELIN-2318) ### How should this be tested? check in #2198 ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: Khalid Huseynov <khalidhnv@gmail.com> Author: LeiWang <wanglei6744@163.com> Closes #2247 from khalidhuseynov/fix/branch-0.7-ZEPPELIN-2318 and squashes the following commits: ec23c95 [Khalid Huseynov] edge case logs from error -> warn e4db79c [Khalid Huseynov] fix log d8efb46 [Khalid Huseynov] fix websocket timing e662239 [Khalid Huseynov] add ssl setup 8f8109e [Khalid Huseynov] add close routine 7f3cd50 [Khalid Huseynov] jetty client relay to asyncclient when proxy on a65f735 [Khalid Huseynov] add proxy client with asynclient library 6add668 [Khalid Huseynov] add dependency in pom, resolve coflict d4cacad [LeiWang] fix bugs for timer saver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
it fixes proxy configuration for http client of zeppelinhub storage layer. currently used jetty-client have issue with
httpsover proxy (1, 2), so newhttpcomponentslibrary have been used.What type of PR is it?
Bug Fix | Improvement
Todos
What is the Jira issue?
ZEPPELIN-2318
How should this be tested?
https_proxy)Screenshots (if appropriate)
Questions: