New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-2326] - Updating Geode dependencies and imports due to package rename #2199
Conversation
looks good, could you please setup CI as referenced here https://zeppelin.apache.org/contribution/contributions.html#continuous-integration |
Hi @markito Thanks for your contribution and taking care of Geode interpreter.
Trigger travis CI by pushing new commits or amend your last commit (git commit --amend and git push your-remote HEAD --force) after setup your travis. |
I'm sorry, skipped that part from the contribution guide. Will do and amend. Thanks! |
Done. One job did failed though... Please let me know if I'm missing something else. https://travis-ci.org/markito/zeppelin/jobs/216598191 Thank you! |
I am not sure but the failed test is due to one of flaky tests. Please restart it.
|
@1ambda indeed! I've restarted the CI job and now it's all green! https://travis-ci.org/markito/zeppelin/builds/216598188 |
Great! Then, Please close issue and re-open :) then jenkins will be triggered again. |
@1ambda can you please confirm if the reopened JIRA triggered Jenkins properly ? Thanks! |
@markito Sorry confusing. I meant this PR not the JIRA ticket :) |
No problem, just reopened.... |
CI is green now. LGTM |
Merge into master and branch-0.7 if there are no more comments on this. |
…age rename ### What is this PR for? Updating Geode dependencies and imports due to package rename - ZEPPELIN-2326 ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2326 ### How should this be tested? Same tests. One test (`oqlPdxInstanceResponse`) was failing before this change and it's still failing... Looks like a problem with the mock response, but I've not looked further. All remaining tests are passing. ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: William Markito Oliveira <markito@apache.org> Closes #2199 from markito/master and squashes the following commits: e2c5650 [William Markito Oliveira] Merge branch 'master' of https://github.com/markito/zeppelin 54952a2 [William Markito Oliveira] Updating Geode dependencies and imports due to package rename ededffb [William Markito Oliveira] Updating Geode dependencies and imports due to package rename (cherry picked from commit 2e6f147) Signed-off-by: ahyoungryu <ahyoungryu@apache.org>
What is this PR for?
Updating Geode dependencies and imports due to package rename - ZEPPELIN-2326
What type of PR is it?
Refactoring
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2326
How should this be tested?
Same tests. One test (
oqlPdxInstanceResponse
) was failing before this change and it's still failing... Looks like a problem with the mock response, but I've not looked further. All remaining tests are passing.Questions: