[ZEPPELIN-2448] Fix paragraph navigation issue #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Keyboard events are broadcasted to components in lower tree * Focus was getting transffered to the lower paragraphs, cauing a chaining effect * Making emit synchronous fixes the problem
|
Tested and LGTM |
asfgit
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Keyboard events are broadcasted to components in lower tree * Focus was getting transferred to the lower paragraphs, causing a chaining effect * Making emit synchronous fixes the problem [Bug Fix] * https://issues.apache.org/jira/browse/ZEPPELIN-2448 * Open a notebook with three or more paragraphs (A, B, C, D) one below the other * Hide editor in B and C * Try to navigate A to D * The focus is passed through all four paragraphs * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: sravan <sravans2011@gmail.com> Closes #2290 from sravan-s/ZEPPELIN-2448 and squashes the following commits: a01ba7c [sravan] Fix paragraph navigation issue (cherry picked from commit d82f42d) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
What type of PR is it?
[Bug Fix]
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: