[ZEPPELIN-2512] Prevent slow note, interpreter search. (master, branch-0.7) #2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ambda
changed the title
1ambda
force-pushed
the
ZEPPELIN-2512/add-debounce-for-search-inputs
branch
from
33e0942
to
8730614
Compare
|
Tested with 200+ notebooks and it really helps! CI failure looks irrlevant but could you restart failed job? |
|
@Leemoonsoo Thanks for the review. CI failed but irrelevant. Found the same error in 4 different PRs
might be related with #2300 |
1ambda
force-pushed
the
ZEPPELIN-2512/add-debounce-for-search-inputs
branch
from
8730614
to
20292fb
Compare
|
Merge to master if no further comments! |
asfgit
pushed a commit
that referenced
this pull request
May 15, 2017
…h-0.7) ### What is this PR for? Use debounce in search input to avoid the slow search. See more:  ### What type of PR is it? [Improvement] ### Todos NONE ### What is the Jira issue? [ZEPPELIN-2512](https://issues.apache.org/jira/browse/ZEPPELIN-2512) ### How should this be tested? 1. Create many notes with different names. (50+) 2. Search using note name filter in home and navbar. 3. Do the same thing for interpreters in the interpreter page ### Screenshots (if appropriate) NONE ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes #2324 from 1ambda/ZEPPELIN-2512/add-debounce-for-search-inputs and squashes the following commits: 20292fb [1ambda] feat: Add debounce for interpreter search input b792ee5 [1ambda] feat: Add debounce for note name filter (cherry picked from commit 164db07) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Use debounce in search input to avoid the slow search.
See more:
What type of PR is it?
[Improvement]
Todos
NONE
What is the Jira issue?
ZEPPELIN-2512
How should this be tested?
Screenshots (if appropriate)
NONE
Questions: