Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2122] Add execution time for Spell #2338

Closed

Conversation

1ambda
Copy link
Member

@1ambda 1ambda commented May 11, 2017

What is this PR for?

Add execution time for spell results. See the screenshot section.

What type of PR is it?

[Improvement]

Todos

NONE

What is the Jira issue?

ZEPPELIN-2122

How should this be tested?

  1. Install any spell (e.g the eco spell)
  2. Execute and check that the paragraph has valid execution time.

Screenshots (if appropriate)

spell_exec2

2122_spell_execution_time

Questions:

  • Does the licenses files need update? - NO
  • Is there breaking changes for older versions? - NO
  • Does this needs documentation? - NO

@1ambda 1ambda changed the title [ZEPPELIN-2122] Add execution time for spell results [ZEPPELIN-2122] Add execution time for Spell May 11, 2017
@1ambda 1ambda force-pushed the ZEPPEILN-2122/add-execution-time-for-spell branch from 0da14b0 to 2417428 Compare May 13, 2017 12:05
@1ambda 1ambda closed this May 13, 2017
@1ambda 1ambda reopened this May 13, 2017
@soralee
Copy link
Contributor

soralee commented May 16, 2017

Tested and LGTM!

@1ambda
Copy link
Member Author

1ambda commented May 17, 2017

Thanks for the review @soralee!

@1ambda 1ambda changed the title [ZEPPELIN-2122] Add execution time for Spell [ZEPPELIN-2122][WIP] Add execution time for Spell May 21, 2017
@Leemoonsoo
Copy link
Member

@1ambda is this pr WIP?

@1ambda
Copy link
Member Author

1ambda commented May 23, 2017

@Leemoonsoo No. I have just changed the title again.

@1ambda 1ambda changed the title [ZEPPELIN-2122][WIP] Add execution time for Spell [ZEPPELIN-2122] Add execution time for Spell May 23, 2017
@Leemoonsoo
Copy link
Member

LGTM and merge to master if no further comment

@asfgit asfgit closed this in 1a3ae42 May 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants