[branch-0.7] missed try catch. #2353
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ambda
reviewed
May 19, 2017
| try { | ||
| interpreterSettingManager.removeNoteInterpreterSettingBinding(subject.getUser(), id); | ||
| } catch (IOException e) { | ||
| logger.error(e.toString(), e); |
There was a problem hiding this comment.
Is it ok not to return here? If we get errors while removing interpreter setting binding. (LINE 342)
There was a problem hiding this comment.
Your opinion is worth thinking about.
but, the intent of this fix is to make the build successful,
and It is to unify the code of the master branch and branch-0.7.
Therefore, you can not modify it in this PR.
Sorry ;-(
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's merge this PR as a hotfix and then address improvement in another PR.
|
merge |
asfgit
pushed a commit
that referenced
this pull request
May 21, 2017
### What is this PR for? Currently we can not build on branch-0.7 The cause is a missed try catch. So, I fixed this part. ### What type of PR is it? Hot Fix ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: CloverHearts <cloverheartsdev@gmail.com> Closes #2353 from cloverhearts/missing-try-catch and squashes the following commits: 8a9ea5c [CloverHearts] missing try catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Currently we can not build on branch-0.7
The cause is a missed try catch.
So, I fixed this part.
What type of PR is it?
Hot Fix
Questions: