[ZEPPELIN-2574] Improve about dialog style
#2360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ambda
changed the title
about dialog style
1ambda
changed the title
about dialog styleabout dialog style
|
@soralee Could you help review this? |
|
@1ambda Thanks for improving dialog! |
|
Tested and LGTM! |
|
LGTM and Merge to master if no further comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Improve
aboutdialog style. See the attached screenshots.What type of PR is it?
[Improvement]
Todos
DONE
What is the Jira issue?
ZEPPELIN-2574
How should this be tested?
mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restartlocalhost:8080About ZeppelinbuttonScreenshots (if appropriate)
Before
After
Questions: