[ZEPPELIN-2152] Fix for npe in Helium loading when no proxies are set #2380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@1ambda , my bad, failing to realize this would not work when no proxies are set. |
|
@necosta Thanks for the quick fix. But can't enable helium packages at all. ERROR [2017-05-31 09:39:15,638] ({qtp832702943-60} HeliumBundleFactory.java[getProxyConfig]:171) -
java.lang.NullPointerException
at java.net.URI$Parser.parse(URI.java:3023)
at java.net.URI.<init>(URI.java:595)
at org.apache.zeppelin.helium.HeliumBundleFactory.getProxyConfig(HeliumBundleFactory.java:169)
at org.apache.zeppelin.helium.HeliumBundleFactory.npmCommand(HeliumBundleFactory.java:665)
at org.apache.zeppelin.helium.HeliumBundleFactory.npmCommand(HeliumBundleFactory.java:671)
at org.apache.zeppelin.helium.HeliumBundleFactory.downloadPackage(HeliumBundleFactory.java:278)
at org.apache.zeppelin.helium.HeliumBundleFactory.buildPackage(HeliumBundleFactory.java:447)
at org.apache.zeppelin.helium.Helium.enable(Helium.java:314) |
necosta
force-pushed
the
zeppelin2152-patch
branch
from
3fd80d5
to
cb25cd7
Compare
|
Tested and LGTM. |
asfgit
pushed a commit
that referenced
this pull request
May 31, 2017
Emergency fix for npe when calling Helium and with no proxies env variables set. Bug Fix https://issues.apache.org/jira/browse/ZEPPELIN-2152 * clone new zeppelin repository * unset http_proxy/https_proxy env variables (if set) * build ` mvn clean package -DskipTests;` * start zeppelin instance * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Nelson Costa <nelson.costa85@gmail.com> Closes #2380 from necosta/zeppelin2152-patch and squashes the following commits: cb25cd7 [Nelson Costa] [ZEPPELIN-2152] Fix for npe in Helium loading when no proxies are set (cherry picked from commit 88c5c3c) Signed-off-by: Lee moon soo <moon@apache.org>
|
Thanks guys! I was having some issues testing this without proxies so really appreciated you testing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Emergency fix for npe when calling Helium and with no proxies env variables set.
What type of PR is it?
Bug Fix
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2152
How should this be tested?
mvn clean package -DskipTests;Questions: