Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2652] Can't open spark tutorial note in 0.8.0-SNAPSHOT #2432

Closed
wants to merge 1 commit into from

Conversation

tae-jun
Copy link
Contributor

@tae-jun tae-jun commented Jun 23, 2017

What is this PR for?

Fix the bug which cannot open a note containing a dynamic form.

It is not a problem of backward version compatibility.
I checked that it still cannot open the note created on v0.8.0.

With the line I added, now it works well.

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2652

How should this be tested?

  • Create a note with dynamic form
  • Reload notes
  • Try to open the note

Questions:

  • Does the licenses files need update? NO
  • Is there breaking changes for older versions? NO
  • Does this needs documentation? NO

@tae-jun
Copy link
Contributor Author

tae-jun commented Jun 23, 2017

@zjffdu Hi, could you please review this? I think this is related to #2245.

I am not sure that I did the right thing.
Is Input class an abstract class?

Thanks 😄

@zjffdu
Copy link
Contributor

zjffdu commented Jun 23, 2017

Thanks @tae-jun , I also fix it in #2272. The right fix should use the same gson as Note. Because GUI is part of Note.

@tinkoff-dwh
Copy link
Contributor

LGTM. but try fix ci (restart failed jobs)

@soralee
Copy link
Contributor

soralee commented Jun 23, 2017

LGTM! Make sure that CI become green.

@tae-jun
Copy link
Contributor Author

tae-jun commented Jun 23, 2017

@tinkoff-dwh @soralee Thanks for the reviews 😄

@tae-jun
Copy link
Contributor Author

tae-jun commented Jun 23, 2017

@zjffdu Thanks for the review! I see.

Then would it better to close this PR and wait for it?
What do you think? :)

@zjffdu
Copy link
Contributor

zjffdu commented Jun 23, 2017

@tae-jun please close it, it will be fixed in #2272. Thanks

@tae-jun
Copy link
Contributor Author

tae-jun commented Jun 23, 2017

@zjffdu Ok. Thanks!

@tae-jun tae-jun closed this Jun 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants