[WIP][ZEPPELIN-2726] Move angular related pkgs from bower to npm (zeppelin-web) #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soralee Could you help review thid? |
|
It looks sounds good! |
1ambda
changed the title
sravan-s
reviewed
Jul 6, 2017
| <script src="bower_components/angular-route/angular-route.js"></script> | ||
| <script src="bower_components/angular-resource/angular-resource.js"></script> | ||
| <script src="bower_components/angular-bootstrap/ui-bootstrap-tpls.js"></script> | ||
| <script src="bower_components/angular/angular.js"></script> |
There was a problem hiding this comment.
Do we still need angular like this?
There was a problem hiding this comment.
because angular-websocket requires it.
|
Thanks for the review. @soralee @sravan-s we are using annotation for angular, but two angular conflicts. (bower side required by angular-websocket) Thus, I will change this PR as WIP and comment after the fix.
|
1ambda
changed the title
|
Will be handled later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Move angular related packages from bower to npm. Because bower team recommends using npm (or yarn) instead of bower. It will not be maintained.
For angular-websocket, can't move it to npm currently. As it's tightly tangled with node packages like (ws, fs, tls, ...) which are not available on the browser side. We can solve this problem after applying webpack2+
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
ZEPPELIN-2726
How should this be tested?
CI will test it, all existing functionalities should work properly.
Screenshots (if appropriate)
NONE
Questions: