[ZEPPELIN-2648] Fix spark module build problem with scala-2.10 profile #2470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove scala version in spark2 profile , we should compose scala profile and spark profile to address scala and spark version * address scalaVersion evidently in maven-scala-plugin
jongyoul
approved these changes
Jul 7, 2017
felixcheung
approved these changes
Jul 7, 2017
|
@felixcheung The initial builds assume scala profile and spark profile together do the right version thing. This PR just fix the bug to ensure it works. |
|
We need do the same thing for spark-dependencies/pom.xml |
|
@zjffdu remove scala version in spark-dependencies. |
felixcheung
approved these changes
Jul 10, 2017
|
LGTM |
|
@reminia Could you try restart failed build jobs and see if it goes green? |
|
@Leemoonsoo restart the failed jobs, CI looks good now. |
|
Thanks @reminia for the fix. Merge to master and branch-0.7 |
asfgit
pushed a commit
that referenced
this pull request
Jul 13, 2017
* remove scala version in spark2 profile , we should compose scala profile and spark profile to address scala and spark version * address scalaVersion evidently in maven-scala-plugin details by ZEPPELIN-2648 [Bug Fix] None * https://issues.apache.org/jira/browse/ZEPPELIN-2648 execute below command and check whether the zeppelin-spark artifact is build based on specified scala and spark version. mvn clean package -Pscala-2.10 -Pspark-2.1 mvn clean package -Pscala-2.11 -Pspark-2.1 * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: lichenyang <lichenyang@cmss.chinamobile.com> Closes #2470 from reminia/zeppelin-2648 and squashes the following commits: 31c7aa5 [lichenyang] remove scala version in the spark-dependencies pom fb57494 [lichenyang] [ZEPPELIN-2648] Fix spark module build problem with scala-2.10 profile (cherry picked from commit 3f9ef6e) Signed-off-by: Lee moon soo <moon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
details by ZEPPELIN-2648
What type of PR is it?
[Bug Fix]
Todos
None
What is the Jira issue?
How should this be tested?
execute below command and check whether the zeppelin-spark artifact is build based on specified scala and spark version.
mvn clean package -Pscala-2.10 -Pspark-2.1
mvn clean package -Pscala-2.11 -Pspark-2.1
Screenshots (if appropriate)
Questions: