[ZEPPELIN-2778] Unit test for credential module (zeppelin-web) #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sravan-s
approved these changes
Jul 17, 2017
| .success(function (data, status, headers, config) { | ||
| $scope.credentialInfo = _.map(data.body.userCredentials, function (value, prop) { | ||
| return {entity: prop, password: value.password, username: value.username} | ||
| .success(function (data, status, headers, config) { |
There was a problem hiding this comment.
@1ambda, In Angular 1.6, Promise.success has been removed. https://github.com/angular/angular.js/blob/master/CHANGELOG.md#160-rainbow-tsunami-2016-12-08
Even though Zeppelin uses 1.5, it's good to be aware of this
There was a problem hiding this comment.
Thanks for the information, we can solve that issue in ZEPPELIN-2788
|
Thanks for the review @sravan-s Merge if no more discussion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Added few test cases for the credential module under
zeppelin-web/Additionally,
configuration.htmlto add the missingtbody.What type of PR is it?
[Improvement]
What is the Jira issue?
ZEPPELIN-2778
How should this be tested?
zeppelin-webyarn install(ornpm install)yarn run test(ornpm run test)The test should pass.
Questions: