[ZEPPELIN-2779] Unit test for job module (zeppelin-web)

[1ambda]

What is this PR for?

Added few test cases for the job module under zeppelin-web/

Additionally,

• removed lodash, q dependency
• converted to JobModule
• refactored jobmanager/*

What type of PR is it?

[Improvement]

What is the Jira issue?

ZEPPELIN-2779

How should this be tested?

1. cd zeppelin-web
2. yarn install (or npm install)
3. yarn run test (or npm run test)

The test should pass.

Questions:

• Does the licenses files need update? - NO
• Is there breaking changes for older versions? - NO
• Does this needs documentation? - NO

[1ambda]

@sravan-s Please help review this PR.

[sravan-s]

We don't have any sucess messages?

[1ambda]

Job page gets updated by websocket when the requested job is done.

[1ambda]

added comment

[sravan-s]

test description (should get proper job type icons) is duplicated in this one and the next one

[1ambda]

Let me fix it.

[1ambda]

removed the duplicated test

[sravan-s]

I scrolled down and saw this is from jobmanager.controller.js. @1ambda, what do you think? Is it a good idea to change the code here?

IMO, The logic here seems a bit complicated. A lot of side effects are happening inside notes.map
It would be helpful, if we can simplify the logic or have a small one line comment describing what's happening

[1ambda]

Let's keep that part :)

[1ambda]

@sravan-s I updated the PR, now websocket (un)subscription is handled in this way (2e12c21)

// job.component.js
  function init() {
    JobManagerService.getJobs()
    JobManagerService.subscribeSetJobs($scope, setJobsCallback)
    JobManagerService.subscribeUpdateJobs($scope, updateJobsCallback)

    $scope.$on('$destroy', function () {
      JobManagerService.disconnect()
    })

Here are logs for it.

[sravan-s]

Looks interesting, let me see :)

[sravan-s]

LGTM

[1ambda]

Thanks for the review @sravan-s

Merge if no more discussion.