[ZEPPELIN-2756] Support ansi escape code for colorizing output in browser #2510

1ambda · 2017-07-31T03:25:54Z

What is this PR for?

Support ANSI escape code for colorizing output in browser using ansi-up

This feature is written based on #2474

What type of PR is it?

[Improvement]

What is the Jira issue?

ZEPPELIN-2756

How should this be tested?

Setup ipython interpreter (or use any interpreter can return ansi escape code)

%python.ipython

import pandas as pd
df = pd.DataFrame({'id':[1,2,3], 'name': ['a', 'b', 'c']})
z.show(df)

Screenshots (if appropriate)

Before

After

Questions:

Does the licenses files need update? - YES, updated
Is there breaking changes for older versions? - YES, all outputs will be escaped
Does this needs documentation? - NO

cloverhearts · 2017-07-31T05:48:01Z

AWESOME!

1ambda · 2017-07-31T05:59:27Z

CI failed, but irrelevant. The error is related with Ipython which is going on #2510

https://api.travis-ci.org/jobs/259230939/log.txt?deansi=true

Results :

Failed tests: 
  SparkParagraphIT.testPySpark:140 Paragraph from SparkParagraphIT of testPySpark result: 
Expected: "test loop 0\ntest loop 1\ntest loop 2"
     but: was "IPython is available, use IPython for PySparkInterpreter"

Tests in error: 
  InterpreterModeActionsIT.testPerUserIsolatedAction:674->logoutUser:154 » Timeout
  InterpreterModeActionsIT.testPerUserScopedAction:336->authenticationUser:136->AbstractZeppelinIT.pollingWait:94 » Timeout
  InterpreterModeActionsIT.testGloballyAction:183->authenticationUser:136->AbstractZeppelinIT.pollingWait:94 » Timeout

Tests run: 30, Failures: 1, Errors: 3, Skipped: 0

zjffdu · 2017-07-31T06:22:59Z

Great, Thanks @1ambda

felixcheung · 2017-08-03T17:22:14Z

.travis.yml


    # Test spark module for 2.2.0 with scala 2.11, livy
    - jdk: "oraclejdk8"
      dist: precise
-      env: SCALA_VER="2.11" SPARK_VER="2.2.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pspark-2.2 -Phadoop-2.6 -Pscala-2.11" SPARKR="true" BUILD_FLAG="package -DskipTests -DskipRat" TEST_FLAG="test -DskipRat" MODULES="-pl .,zeppelin-interpreter,zeppelin-zengine,zeppelin-server,zeppelin-display,spark-dependencies,spark,livy" TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest,org.apache.zeppelin.spark.*,org.apache.zeppelin.livy.* -DfailIfNoTests=false"
+      env: PYTHON="2" SCALA_VER="2.11" SPARK_VER="2.2.0" HADOOP_VER="2.6" PROFILE="-Pweb-ci -Pspark-2.2 -Phadoop-2.6 -Pscala-2.11" SPARKR="true" BUILD_FLAG="install -DskipTests -DskipRat" TEST_FLAG="test -DskipRat" MODULES="-pl .,zeppelin-interpreter,zeppelin-zengine,zeppelin-server,zeppelin-display,spark-dependencies,spark,python,livy" TEST_PROJECTS="-Dtest=ZeppelinSparkClusterTest,org.apache.zeppelin.spark.*,org.apache.zeppelin.livy.* -DfailIfNoTests=false"


change some of these to PYTHON="3"?

felixcheung · 2017-08-03T17:23:42Z

python/README.md

+
+# IPython Architecture
+Current interpreter delegate the whole work to ipython kernel via `jupyter_client`. Zeppelin would launch a python process which host the ipython kernel.
+Zeppelin interpreter process will communicate with the python process via `grpc`. Ideally every feature works in IPython should work in Zeppelin as well.


I think we should scale back on the claim here, as commented before - not everything would work here :)

felixcheung · 2017-08-03T17:24:23Z

python/src/main/java/org/apache/zeppelin/python/IPythonInterpreter.java

+          LOGGER.info("Wait for IPython Kernel to be started");
+        }
+      } catch (Exception e) {
+        // ignore the exception, because is may happen when grpc server has not started yet.


should still log the error/exception?

Leemoonsoo · 2017-08-03T23:03:05Z

@1ambda This PR includes some commits from #2474. Is it intended?

zjffdu · 2017-08-04T02:03:13Z

I think @1ambda just want to verify this PR based my PR, @1ambda can rebase this PR after #2474 is merged.

1ambda · 2017-08-05T01:44:17Z

@zjffdu is right. This is based on #2474 as described in the PR description. Please review last 2 commits except for @zjffdu's commits.

felixcheung · 2017-08-05T06:55:26Z

LG, I guess we go back to 2474 then

zjffdu · 2017-08-28T00:12:15Z

@1ambda I have merged #2474, can you rebase this PR ? Thanks

zjffdu · 2017-08-30T06:14:43Z

ping @1ambda I can do the rebase if you are busy with other stuff and can merge it if you don't mind.

1ambda · 2017-08-31T05:31:34Z

@zjffdu Sorry for the late response. I can do in few hours. Thanks.

1ambda · 2017-08-31T05:54:26Z

rebased to resolve conflict.

1ambda · 2017-08-31T06:06:02Z

Verified that this PR works on master with ipython interpreter. (See the timestamp in the paragraph)

zjffdu · 2017-08-31T06:16:59Z

Thanks @1ambda I also tested it, it works very well. LGTM

felixcheung

LGTM.
I assume AnsiUpConverter.ansi_to_html handles text already in html format correctly?

1ambda · 2017-08-31T08:01:42Z

@felixcheung It will because It converts ANSI codes whatever the content format is.

And I intentionally made a change to convert TEXT format (of Zeppelin output) only to minimize the change.

// ANSI handler is in this function

 const renderText = function (targetElemId, data) {

felixcheung · 2017-08-31T08:13:45Z

got it, thanks!

1ambda · 2017-08-31T09:00:02Z

CI passed. Merge if no more discussion.

felixcheung reviewed Aug 3, 2017

View reviewed changes

1ambda added 2 commits August 31, 2017 14:53

feat: Escape ansi code

89ad7ed

chore: Add license notation for ansi up

143fbbb

1ambda force-pushed the ZEPPELIN-2756/escape-ansi-code-in-browser branch from dd97d00 to 143fbbb Compare August 31, 2017 05:53

felixcheung approved these changes Aug 31, 2017

View reviewed changes

1ambda closed this Aug 31, 2017

1ambda reopened this Aug 31, 2017

1ambda closed this Aug 31, 2017

1ambda reopened this Aug 31, 2017

asfgit closed this in 69d58f3 Sep 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ZEPPELIN-2756] Support ansi escape code for colorizing output in browser #2510

[ZEPPELIN-2756] Support ansi escape code for colorizing output in browser #2510

1ambda commented Jul 31, 2017 •

edited

cloverhearts commented Jul 31, 2017

1ambda commented Jul 31, 2017

zjffdu commented Jul 31, 2017

felixcheung Aug 3, 2017

felixcheung Aug 3, 2017

felixcheung Aug 3, 2017

Leemoonsoo commented Aug 3, 2017

zjffdu commented Aug 4, 2017

1ambda commented Aug 5, 2017

felixcheung commented Aug 5, 2017

zjffdu commented Aug 28, 2017

zjffdu commented Aug 30, 2017 •

edited

1ambda commented Aug 31, 2017

1ambda commented Aug 31, 2017

1ambda commented Aug 31, 2017 •

edited

zjffdu commented Aug 31, 2017 •

edited

felixcheung left a comment

1ambda commented Aug 31, 2017 •

edited

felixcheung commented Aug 31, 2017

1ambda commented Aug 31, 2017

[ZEPPELIN-2756] Support ansi escape code for colorizing output in browser #2510

[ZEPPELIN-2756] Support ansi escape code for colorizing output in browser #2510

Conversation

1ambda commented Jul 31, 2017 • edited

What is this PR for?

What type of PR is it?

What is the Jira issue?

How should this be tested?

Screenshots (if appropriate)

Before

After

Questions:

cloverhearts commented Jul 31, 2017

1ambda commented Jul 31, 2017

zjffdu commented Jul 31, 2017

felixcheung Aug 3, 2017

Choose a reason for hiding this comment

felixcheung Aug 3, 2017

Choose a reason for hiding this comment

felixcheung Aug 3, 2017

Choose a reason for hiding this comment

Leemoonsoo commented Aug 3, 2017

zjffdu commented Aug 4, 2017

1ambda commented Aug 5, 2017

felixcheung commented Aug 5, 2017

zjffdu commented Aug 28, 2017

zjffdu commented Aug 30, 2017 • edited

1ambda commented Aug 31, 2017

1ambda commented Aug 31, 2017

1ambda commented Aug 31, 2017 • edited

zjffdu commented Aug 31, 2017 • edited

felixcheung left a comment

Choose a reason for hiding this comment

1ambda commented Aug 31, 2017 • edited

felixcheung commented Aug 31, 2017

1ambda commented Aug 31, 2017

1ambda commented Jul 31, 2017 •

edited

zjffdu commented Aug 30, 2017 •

edited

1ambda commented Aug 31, 2017 •

edited

zjffdu commented Aug 31, 2017 •

edited

1ambda commented Aug 31, 2017 •

edited