[ZEPPELIN-2859] Use es6 promise in interpreter.controller #2534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested and it works well. LGTM and merge to master if no further discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Replace old angular callbacks with ES6 Promise callbacks.
What type of PR is it?
Improvement
Todos
More of the same works in the rest of the codebase needed.
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2859
How should this be tested?
Open the page
/interpreterand see if it lists interpreters and editing them works correctly.Screenshots (if appropriate)
Questions: