Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-2860] Invalid last job execution time #2540

Closed
wants to merge 3 commits into from
Closed

[ZEPPELIN-2860] Invalid last job execution time #2540

wants to merge 3 commits into from

Conversation

byung-u
Copy link
Contributor

@byung-u byung-u commented Aug 15, 2017

What is this PR for?

Fixed invalid last job execution time on jobmanager page

What type of PR is it?

[Bug Fix]

What is the Jira issue?

How should this be tested?

Run Notebook and check jobmanager page execution time

Screenshots (if appropriate)

image

Questions:

  • Does the licenses files need update? NO
  • Is there breaking changes for older versions? NO
  • Does this needs documentation? NO

@1ambda
Copy link
Member

1ambda commented Aug 16, 2017

It makes sense displaying last execution time instead of creation time of the notebook in the job page.

Tested and works well LGTM.

Let's merge it to master and branch-0.7 if no more discussion.

@1ambda
Copy link
Member

1ambda commented Aug 16, 2017

@byung-u I missed the CI status.

Could you make sure CI is green? I guess there is a checkstyle error.

@byung-u
Copy link
Contributor Author

byung-u commented Aug 16, 2017

Thank you for your review.

I've tried to make CI green, but still fails though.
It looks like r-base-dev package install fail.

2017-08-16 14 37 36

This issue also happened.

@1ambda
Copy link
Member

1ambda commented Aug 16, 2017

It's weird. #2541 passed CI and we modified https://github.com/apache/zeppelin/blob/master/.travis.yml 21 days ago.

I guess

  • the package was not available at that time
  • or ...

Could you trigger CI again? git commit --amend and git push --force would be enough.

Commit for trigger Travis CI.
@1ambda
Copy link
Member

1ambda commented Aug 16, 2017

Some PRs made yesterday passed CI. Could you rebase using current master? I am not sure what base branch you are using.

image

@byung-u
Copy link
Contributor Author

byung-u commented Aug 17, 2017

Move to #2543

@byung-u byung-u closed this Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants