Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-2985: correct grammar in keyboard tooltip #2617

Closed
wants to merge 1 commit into from

Conversation

gef756
Copy link
Contributor

@gef756 gef756 commented Oct 11, 2017

What is this PR for?

The tooltip for "List of shortcut" should read "List of shortcuts" (plural).

What type of PR is it?

Bug Fix

Todos

  • N/A

What is the Jira issue?

How should this be tested?

  • Hover over tooltip. Ensure that tooltip contains changes and behaves like a
    tooltip. (Shows up then hides based on cursor position)

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, could you please check the rest of notebook-actionBar.html to see there is anything else to change?

@1ambda
Copy link
Member

1ambda commented Oct 11, 2017

I tried to search other typo but couldn't find (for viable text, not for css class things). LGTM.

image

@Leemoonsoo
Copy link
Member

Thanks @gef756 for the fix. LGTM

@gef756
Copy link
Contributor Author

gef756 commented Oct 14, 2017

Cool! Do you guys need anything else from my end?

@Leemoonsoo
Copy link
Member

Thanks @gef756 for the contribution!
Merge to master

@asfgit asfgit closed this in 6b0f6e7 Oct 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants