Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3022] The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html #2640

Closed
wants to merge 1 commit into from

Conversation

kjmrknsn
Copy link
Contributor

@kjmrknsn kjmrknsn commented Nov 1, 2017

What is this PR for?

The "Default Interpreter" select box on the "Create new note" modal dialog has no contents when it is opened via the "Create new note" link on $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html.

Fix $
{ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html so that NoteCreateCtrl.getInterpreterSettings() is invoked when the "Create new note" link is clicked.

What type of PR is it?

[Bug Fix]

Todos

What is the Jira issue?

How should this be tested?

  • Tested manually
    • Before: "Default Interpreter" select box has no options
      • zeppelin-3022_before
    • After: "Default Interpreter" select box has options successfully
      • zeppelin-3022_after

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

…ew note" modal dialog has no contents when it is opened via the "Create new note" link on ${ZEPPELIN_HOME}/webapps/webapp/app/home/notebook.html
@Leemoonsoo
Copy link
Member

Thanks @kjmrknsn for the fix!

CI job 7.3 and 7.4 failed and looks like it's flaky test. https://travis-ci.org/kjmrknsn/zeppelin/builds/295636412

Could you try re-run failed tests and see if they goes green?

@kjmrknsn
Copy link
Contributor Author

kjmrknsn commented Nov 2, 2017

@Leemoonsoo The builds are rerun and passed. Thanks.
https://travis-ci.org/kjmrknsn/zeppelin/builds/295636412

@Leemoonsoo
Copy link
Member

Thanks @kjmrknsn. LGTM and Merge to master if no further comments

@asfgit asfgit closed this in aa01d9e Nov 6, 2017
@kjmrknsn kjmrknsn deleted the ZEPPELIN-3022 branch November 6, 2017 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants