Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3025] Windows Build Error #2646

Closed
wants to merge 7 commits into from
Closed

Conversation

conker84
Copy link
Contributor

@conker84 conker84 commented Nov 2, 2017

What is this PR for?

When i try to build Zeppelin from apache master repo on Windows 10 i get this error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.8:copy (copy-artifact) on project zeppelin-interpreter: Error copying artifact from C:\Users\Andrea\workspace_zeppelin\zeppelin-master\zeppelin-interpreter\target\zeppelin-interpreter-0.8.0-SNAPSHOT.jar to C:\Users\Andrea\workspace_zeppelin\zeppelin-master\zeppelin-interpreter\interpreter\Zeppelin: Interpreter\zeppelin-interpreter-0.8.0-SNAPSHOT.jar

What type of PR is it?

[Bug Fix]

Todos

  • - Change build dir

What is the Jira issue?

ZEPPELIN-3025

How should this be tested?

  • Build the project in Windows env

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, project.name would not be right, I think
@zjffdu

let's wait for CI.

@zjffdu
Copy link
Contributor

zjffdu commented Nov 3, 2017

@conker84 Could you try to change the project name to Zeppelin Interpreter, I think the root cause is that Zeppelin: Interpreter is invalid for windows path.

@conker84
Copy link
Contributor Author

conker84 commented Nov 3, 2017

@zjffdu the cause is totaly because of the : in the project.name, but it almost in every pom (Zeppelin: Elasticsearch interpreter, Zeppelin: Apache Cassandra interpreter, ecc...) so i think it's better change the path to project.artifactId.
What do you think?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 3, 2017

Oops, it is caused by last PR. Actually we can just remove this plugin from zeppelin-interpreter module. Now all the interpreter inherit from interpreter-parent module.

@conker84
Copy link
Contributor Author

conker84 commented Nov 3, 2017

@zjffdu so I have to close this PR, right?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 3, 2017

@conker84 you can update this PR by removing this plugin. That should also work for you.

@zjffdu
Copy link
Contributor

zjffdu commented Nov 3, 2017

LGTM, wait for travis pass

@conker84
Copy link
Contributor Author

conker84 commented Nov 3, 2017

CI is failling, the cause seems this:

Failed tests: 
  IPySparkInterpreterTest.testBasics:96 expected:<SUCCESS> but was:<ERROR>

Do you think is related to the PR?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 3, 2017

@conker84 Could you rebase and rerun ?

@conker84
Copy link
Contributor Author

conker84 commented Nov 4, 2017

@zjffdu travis is green now

@zjffdu
Copy link
Contributor

zjffdu commented Nov 4, 2017

Awesome, merge if no more comments

@felixcheung
Copy link
Member

felixcheung commented Nov 4, 2017 via email

@asfgit asfgit closed this in 764fef5 Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants