Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-3309. Import/Clone user not set in Paragraph causes NPE. #2855

Closed
wants to merge 1 commit into from
Closed

ZEPPELIN-3309. Import/Clone user not set in Paragraph causes NPE. #2855

wants to merge 1 commit into from

Conversation

gss2002
Copy link

@gss2002 gss2002 commented Mar 9, 2018

What is this PR for?
During Import/Clone Paragraph set "user" to eliminate NPEs thrown in Helium and other functions leaving unusable notebooks.

What type of PR is it?
[Bug Fix]

Todos

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3309

How should this be tested?
Manually tested using Import/Clone of Notebooks and attempt to adjust bound interpreters

Screenshots (if appropriate)

Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
Author: Greg Senia gsenia@apache.org

@gss2002
Copy link
Author

gss2002 commented Mar 9, 2018

@zjffdu I think this pull request should be good. There looks to be some issues with travis unrelated to the code changes. And I ran the tests a few times not sure whats up with it.

@gss2002
Copy link
Author

gss2002 commented Mar 9, 2018

@zjffdu any reason why travis-ci is failing on disk issues?

travis_time:end:20c877c0:start=1520617145805371744,finish=1520617145811589622,duration=6217878
�[0Ktravis_fold:end:after_failure.11
�[0Ktravis_fold:start:after_failure.12
�[0Ktravis_time:start:09d64a64
�[0K$ cat livy/target/tmp/livy-int-test/MiniYarnMain/target/org.apache.livy.test.framework.MiniYarnMain////stderr
cat: livy/target/tmp/livy-int-test/MiniYarnMain/target/org.apache.livy.test.framework.MiniYarnMain/
///stderr: No such file or directory

travis_time:end:09d64a64:start=1520617145818231645,finish=1520617145824458197,duration=6226552
�[0Ktravis_fold:end:after_failure.12
�[0K
Done. Your build exited with 1.
grep: write error: No space left on device

@zjffdu
Copy link
Contributor

zjffdu commented Mar 10, 2018

@gss2002 Could you try rerun it again ?

@gss2002
Copy link
Author

gss2002 commented Mar 10, 2018

@zjffdu the only test not passing was the e2e test which I am re-runnin gnow.. Let me know if I need to do anything else.

@zjffdu
Copy link
Contributor

zjffdu commented Mar 10, 2018

Thanks @gss2002 , the e2e test is fixed in #2853 , will merge this soon

asfgit pushed a commit that referenced this pull request Mar 10, 2018
What is this PR for?
During Import/Clone Paragraph set "user" to eliminate NPEs thrown in Helium and other functions leaving unusable notebooks.

What type of PR is it?
[Bug Fix]

Todos

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3309

How should this be tested?
Manually tested using Import/Clone of Notebooks and attempt to adjust bound interpreters

Screenshots (if appropriate)

Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
Author: Greg Senia gseniaapache.org

Author: gss2002 <greg@senia.org>

Closes #2855 from gss2002/ZEPPELIN-3309 and squashes the following commits:

b8c35c9 [gss2002] ZEPPELIN-3309. Import/Clone user not set in Paragraph causes NPE.

(cherry picked from commit 803116f)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
@asfgit asfgit closed this in 803116f Mar 10, 2018
jwagun pushed a commit to jwagun/zeppelin that referenced this pull request Apr 23, 2018
What is this PR for?
During Import/Clone Paragraph set "user" to eliminate NPEs thrown in Helium and other functions leaving unusable notebooks.

What type of PR is it?
[Bug Fix]

Todos

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3309

How should this be tested?
Manually tested using Import/Clone of Notebooks and attempt to adjust bound interpreters

Screenshots (if appropriate)

Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
Author: Greg Senia gseniaapache.org

Author: gss2002 <greg@senia.org>

Closes apache#2855 from gss2002/ZEPPELIN-3309 and squashes the following commits:

b8c35c9 [gss2002] ZEPPELIN-3309. Import/Clone user not set in Paragraph causes NPE.
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Jul 4, 2018
What is this PR for?
During Import/Clone Paragraph set "user" to eliminate NPEs thrown in Helium and other functions leaving unusable notebooks.

What type of PR is it?
[Bug Fix]

Todos

What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3309

How should this be tested?
Manually tested using Import/Clone of Notebooks and attempt to adjust bound interpreters

Screenshots (if appropriate)

Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
Author: Greg Senia gseniaapache.org

Author: gss2002 <greg@senia.org>

Closes apache#2855 from gss2002/ZEPPELIN-3309 and squashes the following commits:

b8c35c9 [gss2002] ZEPPELIN-3309. Import/Clone user not set in Paragraph causes NPE.

(cherry picked from commit 803116f)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
(cherry picked from commit ccaa0de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants