ZEPPELIN-3331. Use NullLifecycleManager by default #2878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asfgit
pushed a commit
that referenced
this pull request
Mar 17, 2018
### What is this PR for? Just keep the behavior consistent with previous version. So use NullLifecycleManager by default, user need to configure zeppelin-site.xml to enable TimeoutLifecycleManager ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3331 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #2878 from zjffdu/ZEPPELIN-3331 and squashes the following commits: 5c94e36 [Jeff Zhang] ZEPPELIN-3331. Use NullLifecycleManager by default (cherry picked from commit 233c098) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
|
hey @zjffdu thanks for making all these improvements, could we make sure there is at least one review before merging? |
jwagun
pushed a commit
to jwagun/zeppelin
that referenced
this pull request
Apr 23, 2018
### What is this PR for? Just keep the behavior consistent with previous version. So use NullLifecycleManager by default, user need to configure zeppelin-site.xml to enable TimeoutLifecycleManager ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3331 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#2878 from zjffdu/ZEPPELIN-3331 and squashes the following commits: 5c94e36 [Jeff Zhang] ZEPPELIN-3331. Use NullLifecycleManager by default
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
Just keep the behavior consistent with previous version. So use NullLifecycleManager by default, user need to configure zeppelin-site.xml to enable TimeoutLifecycleManager [ Improvement ] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-3331 * CI pass * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#2878 from zjffdu/ZEPPELIN-3331 and squashes the following commits: 5c94e36 [Jeff Zhang] ZEPPELIN-3331. Use NullLifecycleManager by default (cherry picked from commit 233c098) Signed-off-by: Jeff Zhang <zjffdu@apache.org> (cherry picked from commit b08bf5e) Change-Id: I7c05bd10b29cbe98e1974b0109dfdb12f39890fd
|
The documentation is wrong though:
I ended up here trying to figure out why it didn't work when I looked at the zeppelin-site.xml without syntax highlighting (I didn't notice that this section was commented out). |
|
It would be nice if you could open a PR that would solve this documentation problem. |
|
Sure, here is a quick and dirty MR using GitHub's web editor: #3962 |
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2020
### What is this PR for? Fix the default interpreter lifecycle documentation following #2878 (comment). ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3331 Author: Jocelyn Turcotte <turcotte.j@gmail.com> Closes #3962 from jturcotte/patch-1 and squashes the following commits: 7337b7c [Jocelyn Turcotte] ZEPPELIN-3331: Fix the default interpreter lifecycle documentation
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2020
### What is this PR for? Fix the default interpreter lifecycle documentation following #2878 (comment). ### What type of PR is it? Documentation ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3331 Author: Jocelyn Turcotte <turcotte.j@gmail.com> Closes #3962 from jturcotte/patch-1 and squashes the following commits: 7337b7c [Jocelyn Turcotte] ZEPPELIN-3331: Fix the default interpreter lifecycle documentation (cherry picked from commit 26321da) Signed-off-by: Philipp Dallig <philipp.dallig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Just keep the behavior consistent with previous version. So use NullLifecycleManager by default, user need to configure zeppelin-site.xml to enable TimeoutLifecycleManager
What type of PR is it?
[ Improvement ]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: