[Zeppelin-2572] multiple paragraphs actions #2952

Savalek · 2018-04-28T11:11:16Z

What is this PR for?

This PR adds the ability to perform actions on several paragraphs simultaneously. He adds the checkbox to each paragraph. When you select at least one paragraph in the action bar, buttons appear that perform actions on the selected paragraphs.

What type of PR is it?

Feature

What is the Jira issue?

ZEPPELIN-2572

Screenshots (if appropriate)

Questions:

Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? no

# Conflicts: # zeppelin-integration/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java # zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java

r-kamath · 2018-05-02T11:23:38Z

Run all/selected button behavior is not right when selected paragraphs are removed. Until reset selections/refresh the page retains the selection count.

Savalek · 2018-05-03T08:17:23Z

@r-kamath, I fixed this flaw.

r-kamath · 2018-05-07T05:02:38Z

zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java

@@ -291,6 +291,9 @@ public void onMessage(NotebookSocket conn, String msg) {
        case MOVE_PARAGRAPH:
          moveParagraph(conn, userAndRoles, notebook, messagereceived);
          break;
+        case MOVE_SEVERAL_PARAGRAPHS:


can we use MOVE_PARAGRAPHS for moving multiple paragraphs?

r-kamath · 2018-05-07T05:05:06Z

zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java

@@ -1641,6 +1686,35 @@ private void moveParagraph(NotebookSocket conn, HashSet<String> userAndRoles, No
        new Message(OP.PARAGRAPH_MOVED).put("id", paragraphId).put("index", newIndex));
  }

+  private void moveSeveralParagraphs(NotebookSocket conn, HashSet<String> userAndRoles,


moveParagraphs

r-kamath · 2018-05-07T05:08:25Z

zeppelin-web/src/app/notebook/notebook-actionBar.html

+              ng-hide="viewOnly"
+              tooltip-placement="bottom" uib-tooltip="Enable/Disable for running"
+              ng-disabled="revisionView">
+        <i ng-class="isAnableRun ? 'fa fa-lock' : 'fa fa-unlock'"></i>


isEnableRun

Savalek · 2018-05-07T11:43:44Z

@r-kamath, I fixed it.

r-kamath · 2018-05-08T10:22:17Z

LGTM

r-kamath · 2018-05-09T01:41:35Z

@jongyoul @zjffdu @prabhjyotsingh please review

Tagar

looks good to me. left one minor spelling comment.
tested this manually. will deploy to users soon.
great improvement.

Tagar · 2018-05-23T22:53:59Z

zeppelin-web/src/app/notebook/notebook-actionBar.html

+              data-toggle="modal" data-target="#noteCreateModal" data-clone-note="true"
+              data-only-selected-paragraphs="true"
+              data-selected-paragraphs="{{getSelectedParagraphs()}}"
+              tooltip-placement="bottom" uib-tooltip="Clone this note use selected paragraphs">


minor: Clone this note using selected paragraphs

Tagar · 2018-05-23T22:56:43Z

zeppelin-web/src/app/notebook/notebook-actionBar.html

              ng-class="{'disabled':isNoteRunning()}"
-              tooltip-placement="bottom" uib-tooltip="Run all paragraphs"
+              tooltip-placement="bottom"
+              uib-tooltip="{{isSelectionMode() ? 'Run selected paragraph' : 'Run all paragraphs'}}"


selected paragraphs

Tagar · 2018-05-23T22:57:09Z

zeppelin-web/src/app/notebook/notebook-actionBar.html

+              class="btn btn-default btn-xs"
+              ng-if="isSelectionMode()"
+              ng-click="removeSelectedParagraph(note.id)"
+              tooltip-placement="bottom" uib-tooltip="Delete selected paragraph">


"delete selected paragraphs"

Tagar · 2018-05-25T17:34:58Z

thank you @Savalek

@zjffdu would it be possible to merge this to master? (and not to 0.8)
thanks!

# Conflicts: # zeppelin-web/src/app/notebook/notebook.controller.js # zeppelin-web/src/app/notebook/notebook.css

Tagar · 2018-06-05T16:24:18Z

zeppelin-web/src/app/notebook/paragraph/paragraph-control.html

+    <span class="{{selectedParagraphsIds.has(paragraph.id) ? 'icon-check checked-paragraph-check-button' : 'icon-plus'}}"
+          tooltip-placement="top"
+          style="cursor:pointer"
+          uib-tooltip="Select a paragraph"


"Add this paragraph to selection"

Tagar · 2018-06-05T16:26:21Z

We were using PR this in prod for a couple of weeks. Works great.
Left one additional comment based on users feedback.
"Select a paragraph" tooltip change to "Add this paragraph to selection" would be better,
as it selects that particular paragraph and based on tooltip users can see that it talks
about multi-paragraph selection.

Savalek · 2018-06-06T09:49:30Z

@Tagar, thanks. I changed the tooltip.

# Conflicts: # zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java # zeppelin-web/src/components/websocket/websocket-event.factory.js # zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java

jongyoul · 2018-07-06T06:37:19Z

Let me test it in my local

Savalek · 2018-08-07T14:17:58Z

Changed the UI and add shortcut to select/deselect paragraph.

@jongyoul, what you say about it?

zjffdu · 2018-08-08T01:57:44Z

zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java

@@ -191,7 +191,13 @@
    INTERPRETER_INSTALL_RESULT,   // [s-c] Status of an interpreter installation
    COLLABORATIVE_MODE_STATUS,    // [s-c] collaborative mode status
    PATCH_PARAGRAPH,              // [c-s][s-c] patch editor text
-    NOTICE                        // [s-c] Notice
+    NOTICE,                       // [s-c] Notice
+    REMOVE_SELECTED_PARAGRAPHS,   // [c-s] remove selected paragraphs


Can we merge these with the single paragraph operation to reduce code duplication ? Otherwise if we introduce new operation in future, we have to introduce 2 message, one for single paragraph, another for multiple paragraph, which is inefficient.

Thanks. I'll think about how to improve this.

Savalek · 2018-08-16T09:39:28Z

refactored and transferred to Zeppelin-2572 ver2

### What is this PR for? This PR adds the ability to perform actions on several paragraphs simultaneously. He adds the checkbox to each paragraph. When you select at least one paragraph in the action bar, buttons appear that perform actions on the selected paragraphs. ### What type of PR is it? Feature ### What is the Jira issue? [ZEPPELIN-2572](https://issues.apache.org/jira/browse/ZEPPELIN-2572) ZP-24 apache#2952 declined. apache#3145 #6 ### Screenshots (if appropriate) ![mult_v2](https://user-images.githubusercontent.com/30798933/44201040-e4a0d000-a150-11e8-955c-2837683f4651.gif) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no

Savalek added 3 commits April 17, 2018 17:33

add multiple paragraphs actions

9f9a7ca

Merge remote-tracking branch 'apache/master' into ZEPPELIN-2572

fa594fa

# Conflicts: # zeppelin-integration/src/test/java/org/apache/zeppelin/integration/ParagraphActionsIT.java # zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/socket/Message.java

[ZEPPELIN-2572] remove duplicate 'REMOVE_NOTE_FORMS'

289cc38

[ZEPPELIN-2572] remove deleted paragraph from selection list

7ddb0f6

r-kamath reviewed May 7, 2018

View reviewed changes

[ZEPPELIN-2572] refactoring

5af8b99

asfgit force-pushed the master branch from b11d355 to 3712ce6 Compare May 9, 2018 05:45

Tagar reviewed May 23, 2018

View reviewed changes

[ZEPPELIN-2572] small fix

77809e2

Merge remote-tracking branch 'apache/master' into ZEPPELIN-2572

c4fdf5d

# Conflicts: # zeppelin-web/src/app/notebook/notebook.controller.js # zeppelin-web/src/app/notebook/notebook.css

Tagar reviewed Jun 5, 2018

View reviewed changes

[ZEPPELIN-2572] change tooltip

0dba9d0

Savalek added 2 commits June 13, 2018 11:19

Merge remote-tracking branch 'apache/master' into ZEPPELIN-2572

2082c34

Savalek added 2 commits August 7, 2018 10:16

Merge branch 'master' into ZEPPELIN-2572

1b419d8

[ZEPPELIN-2572] ui change. add shortcut to select paragraph.

6cfe75a

zjffdu reviewed Aug 8, 2018

View reviewed changes

Savalek closed this Aug 16, 2018

Savalek mentioned this pull request Nov 2, 2018

[ZP-24] multiple paragraphs actions Tinkoff/zeppelin#6

Merged

Savalek deleted the ZEPPELIN-2572 branch January 25, 2019 12:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Zeppelin-2572] multiple paragraphs actions #2952

[Zeppelin-2572] multiple paragraphs actions #2952

Savalek commented Apr 28, 2018

r-kamath commented May 2, 2018

Savalek commented May 3, 2018

r-kamath May 7, 2018

r-kamath May 7, 2018

r-kamath May 7, 2018

Savalek commented May 7, 2018

r-kamath commented May 8, 2018

r-kamath commented May 9, 2018

Tagar left a comment

Tagar May 23, 2018

Tagar May 23, 2018

Tagar May 23, 2018

Tagar commented May 25, 2018

Tagar Jun 5, 2018

Tagar commented Jun 5, 2018

Savalek commented Jun 6, 2018

jongyoul commented Jul 6, 2018

Savalek commented Aug 7, 2018

zjffdu Aug 8, 2018

Savalek Aug 9, 2018

Savalek commented Aug 16, 2018

[Zeppelin-2572] multiple paragraphs actions #2952

[Zeppelin-2572] multiple paragraphs actions #2952

Conversation

Savalek commented Apr 28, 2018

What is this PR for?

What type of PR is it?

What is the Jira issue?

Screenshots (if appropriate)

Questions:

r-kamath commented May 2, 2018

Savalek commented May 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Savalek commented May 7, 2018

r-kamath commented May 8, 2018

r-kamath commented May 9, 2018

Tagar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tagar commented May 25, 2018

Choose a reason for hiding this comment

Tagar commented Jun 5, 2018

Savalek commented Jun 6, 2018

jongyoul commented Jul 6, 2018

Savalek commented Aug 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Savalek commented Aug 16, 2018