[ZEPPELIN-3476] change description "auto-restart interpreter on cron execution" #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
felixcheung
reviewed
May 30, 2018
| @@ -45,7 +45,7 @@ You can set the cron schedule by filling in this form. Please see [Cron Trigger | |||
|
|
|||
| You can set the cron executing user by filling in this form and press the enter key. | |||
|
|
|||
| ### auto-restart interpreter on cron execution | |||
| ### After execution close the interpreter | |||
There was a problem hiding this comment.
maybe "stop" is better than "close"? I think that's the terminology used elsewhere
https://zeppelin.apache.org/docs/0.7.3/manual/interpreters.html#what-is-interpreter-group
|
@felixcheung, agree with you. Replaced the close on stop. |
|
LGTM |
|
will merge this if there are no more discussions |
|
@Savalek can you update the title of this PR? |
Savalek
changed the title
|
@felixcheung, I did it. |
asfgit
pushed a commit
that referenced
this pull request
Jun 13, 2018
…execution" Description "auto-restart interpreter on cron execution" is does not quite fit in the sense. Documentation [ZEPPELIN-3476](https://issues.apache.org/jira/browse/ZEPPELIN-3476)  Author: Savalek <def113@mail.ru> Closes #2991 from Savalek/ZEPPELIN-3476 and squashes the following commits: 4916b0d [Savalek] [ZEPPELIN-3476] replace "close" on "stop" d2e9c78 [Savalek] [ZEPPELIN-3476] change description Change-Id: Ic8a0d283268f843f0ec440b2203c027fea0ffb2b (cherry picked from commit ee06cf0) Signed-off-by: Renjith Kamath <rkamath@apache.org>
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Jul 4, 2018
…execution" Description "auto-restart interpreter on cron execution" is does not quite fit in the sense. Documentation [ZEPPELIN-3476](https://issues.apache.org/jira/browse/ZEPPELIN-3476)  Author: Savalek <def113@mail.ru> Closes apache#2991 from Savalek/ZEPPELIN-3476 and squashes the following commits: 4916b0d [Savalek] [ZEPPELIN-3476] replace "close" on "stop" d2e9c78 [Savalek] [ZEPPELIN-3476] change description Change-Id: Ic8a0d283268f843f0ec440b2203c027fea0ffb2b (cherry picked from commit ee06cf0) Signed-off-by: Renjith Kamath <rkamath@apache.org>
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…execution" Description "auto-restart interpreter on cron execution" is does not quite fit in the sense. Documentation [ZEPPELIN-3476](https://issues.apache.org/jira/browse/ZEPPELIN-3476)  Author: Savalek <def113@mail.ru> Closes apache#2991 from Savalek/ZEPPELIN-3476 and squashes the following commits: 4916b0d [Savalek] [ZEPPELIN-3476] replace "close" on "stop" d2e9c78 [Savalek] [ZEPPELIN-3476] change description Change-Id: Ic8a0d283268f843f0ec440b2203c027fea0ffb2b
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…execution" Description "auto-restart interpreter on cron execution" is does not quite fit in the sense. Documentation [ZEPPELIN-3476](https://issues.apache.org/jira/browse/ZEPPELIN-3476)  Author: Savalek <def113@mail.ru> Closes apache#2991 from Savalek/ZEPPELIN-3476 and squashes the following commits: 4916b0d [Savalek] [ZEPPELIN-3476] replace "close" on "stop" d2e9c78 [Savalek] [ZEPPELIN-3476] change description Change-Id: Ic8a0d283268f843f0ec440b2203c027fea0ffb2b (cherry picked from commit ee06cf0) Signed-off-by: Renjith Kamath <rkamath@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Description "auto-restart interpreter on cron execution" is does not quite fit in the sense.
What type of PR is it?
Documentation
What is the Jira issue?
ZEPPELIN-3476
Screenshot