[ZEPPELIN-3528] Ordering by interpreter name in same interpreter group #3005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
### What is this PR for? In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter groups. But interpreter is not ordered in same interpreter group. (It seems to be ordered by hashcode of 'InterpreterSetting') When there are many interpreter in same group and this group is first, user cannot predict what interpreter is showed first. So I think that interpreter need to be ordered by name. ### What type of PR is it? [Improvement] ### Todos * [x] - Modify Code ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3528 ### How should this be tested? * Click 'create new note' ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * No * Is there breaking changes for older versions? * No * Does this needs documentation? * No Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com> Closes apache#3005 from woowahan-jaehoon/ZEPPELIN-3528 and squashes the following commits: 5cb709c [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group
weand
pushed a commit
to weand/zeppelin
that referenced
this pull request
Oct 5, 2018
### What is this PR for? In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter groups. But interpreter is not ordered in same interpreter group. (It seems to be ordered by hashcode of 'InterpreterSetting') When there are many interpreter in same group and this group is first, user cannot predict what interpreter is showed first. So I think that interpreter need to be ordered by name. ### What type of PR is it? [Improvement] ### Todos * [x] - Modify Code ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3528 ### How should this be tested? * Click 'create new note' ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * No * Is there breaking changes for older versions? * No * Does this needs documentation? * No Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com> Closes apache#3005 from woowahan-jaehoon/ZEPPELIN-3528 and squashes the following commits: 5cb709c [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group
2 tasks
asfgit
pushed a commit
that referenced
this pull request
Oct 6, 2018
…erpreter group ### What is this PR for? Merge for branch-0.8. In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter groups. But interpreter is not ordered in same interpreter group. (It seems to be ordered by hashcode of 'InterpreterSetting') When there are many interpreter in same group and this group is first, user cannot predict what interpreter is showed first. So I think that interpreter need to be ordered by name. ### What type of PR is it? [Improvement] ### Todos * [x] - Modify Code ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3528 ### How should this be tested? * Click 'create new note' ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * No * Is there breaking changes for older versions? * No * Does this needs documentation? * No Author: Jaehoon Jeong <jaehoon.jeongwoowahan.com> Closes #3005 from woowahan-jaehoon/ZEPPELIN-3528 and squashes the following commits: 5cb709c [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group ### What is this PR for? A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html ### What type of PR is it? [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] ### Todos * [ ] - Task ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? Author: Jaehoon Jeong <jaehoon.jeong@woowahan.com> Closes #3202 from weand/branch-0.8 and squashes the following commits: 00af514 [Jaehoon Jeong] [ZEPPELIN-3528] Ordering by interpreter name in same interpreter group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In 'Create new note' diagram, 'Default Interpreter' is ordered by only interpreter groups.
But interpreter is not ordered in same interpreter group.
(It seems to be ordered by hashcode of 'InterpreterSetting')
When there are many interpreter in same group and this group is first,
user cannot predict what interpreter is showed first.
So I think that interpreter need to be ordered by name.
What type of PR is it?
[Improvement]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: