Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-3336. Remove sending spark web url to interpreter setting page #3031

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jun 19, 2018

What is this PR for?

This PR is to remove the spark web url of interpreter setting page. As it doesn't make sense to do that. There would many spark interpreter processes associated with one interpreter setting when it is in isolated mode.

What type of PR is it?

[Bug Fix ]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 21, 2018

@felixcheung Mind to review it ? Thanks

@felixcheung
Copy link
Member

felixcheung commented Jun 21, 2018 via email

@zjffdu
Copy link
Contributor Author

zjffdu commented Jun 22, 2018

This is just removing sending web ui to interpreter setting, but we still send job web ui to paragraph. So that user can still see the ui in paragraph.

@felixcheung
Copy link
Member

ok

@asfgit asfgit closed this in adf83a3 Jun 26, 2018
mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
### What is this PR for?
This PR  is to remove the spark web url of interpreter setting page. As it doesn't make sense to do that. There would many spark interpreter processes associated with one interpreter setting when it is in isolated mode.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3336

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#3031 from zjffdu/ZEPPELIN-3336 and squashes the following commits:

e2bf02e [Jeff Zhang] ZEPPELIN-3336. Remove sending spark web url to interpreter setting page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants