Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3080] Removing duplicate Date header #3052

Closed
wants to merge 2 commits into from

Conversation

sjoerdmulder
Copy link
Contributor

What is this PR for?

Removing the duplicate Date header that is also in the wrong format according to the RFC, currently every request contains the following headers (using curl -I)

HTTP/1.1 200 OK
Date: Monday, November 27, 2017 3:20:42 PM UTC
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: authorization,Content-Type
Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
X-FRAME-OPTIONS: SAMEORIGIN
X-XSS-Protection: 1
Content-Type: application/octet-stream
Date: Mon, 27 Nov 2017 15:20:42 GMT
Content-Length: 59
Server: Jetty(9.2.15.v20160210)

What type of PR is it?

Bug Fix

What is the Jira issue?

ZEPPELIN-3080

Questions:

  • Does the licenses files need update?
    Nope
  • Is there breaking changes for older versions?
    Nope
  • Does this needs documentation?
    Nope

@sjoerdmulder
Copy link
Contributor Author

@felixcheung finally got the build working :)

@jongyoul
Copy link
Member

jongyoul commented Jul 5, 2018

LGTM. BTW, is there any issue for the front side?

@sjoerdmulder
Copy link
Contributor Author

I figured it out because we have a server side process (Spray client) doing health-checks and giving warnings about it:

Illegal response header: Illegal 'Date' header: Invalid input 'r', expected ", " or ' ' (line 1, pos 4):
Thursday, July 5, 2018 7:50:52 AM UTC
   ^

@Leemoonsoo
Copy link
Member

LGTM

@asfgit asfgit closed this in 1ec869f Jul 8, 2018
mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
### What is this PR for?
Removing the duplicate Date header that is also in the wrong format according to the RFC, currently every request contains the following headers (using `curl -I`)
```
HTTP/1.1 200 OK
Date: Monday, November 27, 2017 3:20:42 PM UTC
Access-Control-Allow-Credentials: true
Access-Control-Allow-Headers: authorization,Content-Type
Access-Control-Allow-Methods: POST, GET, OPTIONS, PUT, HEAD, DELETE
X-FRAME-OPTIONS: SAMEORIGIN
X-XSS-Protection: 1
Content-Type: application/octet-stream
Date: Mon, 27 Nov 2017 15:20:42 GMT
Content-Length: 59
Server: Jetty(9.2.15.v20160210)
```

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-3080](https://issues.apache.org/jira/browse/ZEPPELIN-3080)

### Questions:
* Does the licenses files need update?
Nope
* Is there breaking changes for older versions?
Nope
* Does this needs documentation?
Nope

Author: Sjoerd Mulder <sjoerdmulder@gmail.com>

Closes apache#3052 from sjoerdmulder/patch-2 and squashes the following commits:

f734c18 [Sjoerd Mulder] Update CorsFilter.java
1ebd1ad [Sjoerd Mulder] Removing duplicate Date header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants