Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-3575. Add 'Copy Column Name' button in visualization table #3081

Closed
wants to merge 1 commit into from

Conversation

mebelousov
Copy link
Contributor

What is this PR for?

Add button to drop-down list in visualization table to copy column name.
I know that column name could be obtained in a different way, for example, by auto-complete.
Nevertheless I think this feature is comfortable.

What type of PR is it?

Feature

What is the Jira issue?

ZEPPELIN-3575

How should this be tested?

  • Manually

Screenshots (if appropriate)

zeppelin-3575

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

Copy link
Member

@jongyoul jongyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with FE, but do you have any idea to test this feature? It would be perfect if you add test case for it.

@mebelousov
Copy link
Contributor Author

@jongyoul I also haven't good idea to write small and useful test.
It's possible to rewrite copyStringToClipboard as pass to function the column number and then put in clipboard column name, although it's not straightforward way.

@jongyoul
Copy link
Member

jongyoul commented Aug 2, 2018

Sorry for the late reply. How about adding an integration test?

@mebelousov
Copy link
Contributor Author

Will try to revert with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants