[ZEPPELIN-3655] Add missing roles information to api/notebook/job/ method #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxygen311
changed the title
|
Can you add unit test ? |
|
@zjffdu |
|
@oxygen311 Could you resolve conflict ? |
zjffdu
reviewed
Jul 26, 2018
bin/common.sh
Outdated
| @@ -16,6 +16,10 @@ | |||
| # limitations under the License. | |||
| # | |||
|
|
|||
| # -agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005 | |||
| # ZEPPELIN_JAVA_OPTS | |||
| export ZEPPELIN_JAVA_OPTS="-agentlib:jdwp=transport=dt_socket,server=y,suspend=n,address=5005" | |||
added 2 commits
July 26, 2018 11:54
…ELIN-3655 # Conflicts: # zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java
|
@zjffdu done |
|
It looks like all the public api in NotebookRestApi miss the role info. Do you see any issue when roles is missing ? I think it is better to set roles properly in some kind of Filter. |
|
@zjffdu |
|
Thanks @oxygen311 LGTM |
mckartha
pushed a commit
to syntechdev/zeppelin
that referenced
this pull request
Aug 9, 2018
…thod ### What is this PR for? Fix bugs with private access interpreter launched with REST by adding missing roles information to `AuthenticationInfo`. ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: oxygen311 <alex39-09@mail.ru> Closes apache#3093 from oxygen311/ZEPPELIN-3655 and squashes the following commits: aa51ca3 [oxygen311] Add roles info to run paragraph method 407b104 [oxygen311] Change 0444284 [oxygen311] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-3655 182dadc [oxygen311] Fix roles info
asfgit
pushed a commit
that referenced
this pull request
Sep 18, 2018
…thod Fix bugs with private access interpreter launched with REST by adding missing roles information to `AuthenticationInfo`. Bug Fix [ZEPPELIN-3655](https://issues.apache.org/jira/projects/ZEPPELIN/issues/ZEPPELIN-3655) * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: oxygen311 <alex39-09@mail.ru> Closes #3093 from oxygen311/ZEPPELIN-3655 and squashes the following commits: aa51ca3 [oxygen311] Add roles info to run paragraph method 407b104 [oxygen311] Change 0444284 [oxygen311] Merge branch 'master' of https://github.com/apache/zeppelin into ZEPPELIN-3655 182dadc [oxygen311] Fix roles info (cherry picked from commit 858cfcd) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Fix bugs with private access interpreter launched with REST by adding missing roles information to
AuthenticationInfo.What type of PR is it?
Bug Fix
What is the Jira issue?
ZEPPELIN-3655
Questions: