[ZEPPELIN-3667] [Improvement] Large CVS download. #3101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagar
reviewed
Jul 28, 2018
| angular.element('body').append('<a id="SaveAsId"></a>'); | ||
| var saveAsElement = angular.element('body > a#SaveAsId'); | ||
| saveAsElement.attr('href', content); | ||
| var url = window.URL.createObjectURL(new Blob([content], {type: 'image/svg;charset=utf-8'})); |
There was a problem hiding this comment.
You are right. Removed it. thank you @Tagar
|
FYI. That download button will be removed by #3013 |
|
Intended for branch-0.7. We use this version of Zeppelin with the posted fix at our organization. Thought it would be useful for folks on the same branch version or EMR folks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
The download CSV feature from the table views fails when the total data accumulated is greater than 2MB on the chrome browser.
encodeURIComponent call has a maxs out for larger sizes of csv, using blob extends csv download size limitations.
What type of PR is it?
[Improvement]
What is the Jira issue?
ZEPPELIN-3667
How should this be tested?
set env variable ZEPPELIN_INTERPRETER_OUTPUT_LIMIT to greater than 2 MB.
Test downloading a small to moderate CSV from the table segment on chrome, safari, opera and firefox.
Test downloading a large CSV(2MB or greater) from the table segment on chrome, safari, opera and firefox.
All downloads should pass.