Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-3668. Can't hide Spark Jobs (Spark UI) button #3104

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Jul 31, 2018

What is this PR for?

This is to fix the bug of unable to hide spark jobs.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • Unit test added
  • Verify it manually as well.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 1, 2018

Will merge if no more comments

@asfgit asfgit closed this in 343fd17 Aug 1, 2018
asfgit pushed a commit that referenced this pull request Aug 1, 2018
This is to fix the bug of unable to hide spark jobs.

[Bug Fix]

* [ ] - Task

* https://issues.apache.org/jira/browse/ZEPPELIN-3668

* Unit test added
* Verify it manually as well.

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #3104 from zjffdu/ZEPPELIN-3668 and squashes the following commits:

c7ddecc [Jeff Zhang] ZEPPELIN-3668. Can't hide Spark Jobs (Spark UI) button

(cherry picked from commit 343fd17)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
@maziyarpanahi
Copy link
Contributor

Hi @zjffdu,
Is it possible to have spark.ui.enabled: true, but hide the Spark Jobs in UI? Or should we not mention spark.ui.enabled at all if we wish not to see the Spark Jobs button in UI?

Many thanks

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 1, 2018

Why would you want to have spark.ui.enabled: true but hide the spark jobs in UI ?

@maziyarpanahi
Copy link
Contributor

maziyarpanahi commented Aug 1, 2018

We don’t provide proxy or any multi-user Spark UI solutions to our data scientists. But as a SysAdmin I need to see the jobs etc. in order to diagnose the problems they have time to time. Also I use it to see if there are other problems with the rest of the cluster (YARN/HDFS).

In Zeppelin 0.7.3 I never mentioned anything about Spark UI and the Zeppelin UI didn’t display this button at all. I know it is nice to have this option by default as people try it on localhost and the UI is useful and accessible but this is not the case in multi-user scenarios as Spark is not offering any multi-user option for its UI right out of the box.

That is why I think it is important to have a setting for Zeppelin to allow admins to turn this feature off (hidden) if they only use Spark UI for debugging. (This can be zeppelin.spark.ui.hidden:false by default for backward compatibility)
What do you think?

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 2, 2018

Thanks @maziyarpanahi It makes sense to me. I created ZEPPELIN-3679 for it

@zjffdu
Copy link
Contributor Author

zjffdu commented Aug 2, 2018

@maziyarpanahi I make a pr for this #3109

@maziyarpanahi
Copy link
Contributor

Many thanks @zjffdu

mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
### What is this PR for?

This is to fix the bug of unable to hide spark jobs.

### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3668

### How should this be tested?
* Unit test added
* Verify it manually as well.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#3104 from zjffdu/ZEPPELIN-3668 and squashes the following commits:

c7ddecc [Jeff Zhang] ZEPPELIN-3668. Can't hide Spark Jobs (Spark UI) button
mckartha pushed a commit to syntechdev/zeppelin that referenced this pull request Aug 9, 2018
This is to fix the bug of unable to hide spark jobs.

[Bug Fix]

* [ ] - Task

* https://issues.apache.org/jira/browse/ZEPPELIN-3668

* Unit test added
* Verify it manually as well.

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#3104 from zjffdu/ZEPPELIN-3668 and squashes the following commits:

c7ddecc [Jeff Zhang] ZEPPELIN-3668. Can't hide Spark Jobs (Spark UI) button

(cherry picked from commit 343fd17)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Apr 29, 2019
This is to fix the bug of unable to hide spark jobs.

[Bug Fix]

* [ ] - Task

* https://issues.apache.org/jira/browse/ZEPPELIN-3668

* Unit test added
* Verify it manually as well.

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#3104 from zjffdu/ZEPPELIN-3668 and squashes the following commits:

c7ddecc [Jeff Zhang] ZEPPELIN-3668. Can't hide Spark Jobs (Spark UI) button

(cherry picked from commit 343fd17)
Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants