Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-3702]. Followup of ZEPPELIN-3681: Use NotebookService in more apis #3133

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Aug 13, 2018

What is this PR for?

Followup of ZEPPELIN-3681, use NotebookService in more apis. and also add unit test for NotebookService.

What type of PR is it?

[Refactoring]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you fix the truncated PR title?

@zjffdu zjffdu force-pushed the ZEPPELIN-3702 branch 3 times, most recently from 1c5fc87 to cbea77a Compare August 15, 2018 07:18
@zjffdu zjffdu changed the title [ZEPPELIN-3702]. Followup of ZEPPELIN-3681: Use NotebookService in mo… [ZEPPELIN-3702]. Followup of ZEPPELIN-3681: Use NotebookService in more apis Aug 15, 2018
@zjffdu zjffdu force-pushed the ZEPPELIN-3702 branch 3 times, most recently from 1ae9035 to 3a7f783 Compare August 16, 2018 02:14
@zjffdu zjffdu force-pushed the ZEPPELIN-3702 branch 4 times, most recently from 22348ae to 275559a Compare August 17, 2018 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants