ZEPPELIN-3735. Wrap WebSocket connection into ConnectionManager #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
force-pushed
the
ZEPPELIN-3735
branch
5 times, most recently
from
73c0ab0
to
7fd5eb2
Compare
|
Will merge if no more comments |
zjffdu
force-pushed
the
ZEPPELIN-3735
branch
2 times, most recently
from
4999753
to
f30dfba
Compare
| userAndRoles = authInfo.getRoles(user); | ||
| userAndRoles.add(user); | ||
| // TODO(zjffdu) is it ok for comment the following line ? | ||
| // notesInfo = generateNotesInfo(false, new AuthenticationInfo(user), userAndRoles); |
There was a problem hiding this comment.
This is the cause of https://issues.apache.org/jira/browse/ZEPPELIN-5061 and needs to be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This a refactoring PR which move all websocket connection related stuff into class
ConnectionManagerWhat type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: