ZEPPELIN-3749. New Spark interpreter has to be restarted two times inorder to work fine for different users #3166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjffdu
force-pushed
the
ZEPPELIN-3749
branch
3 times, most recently
from
0e11b95
to
bf4d156
Compare
… order to work fine for different users
felixcheung
approved these changes
Aug 31, 2018
| sparkSession = null | ||
| if (BaseSparkScalaInterpreter.sessionNum.decrementAndGet() == 0) { | ||
| if (sc != null) { | ||
| sc.stop() |
There was a problem hiding this comment.
I think sc.stop() can throw too, something to consider.
asfgit
pushed a commit
that referenced
this pull request
Sep 4, 2018
…order to work fine for different users This PR fix the issue of scoped mode for new spark interpreter. It will only close SparkContext when there's no other live sessions. [Bug Fix] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-3749 * Unit test is added * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes #3166 from zjffdu/ZEPPELIN-3749 and squashes the following commits: 67ba556 [Jeff Zhang] ZEPPELIN-3749. New Spark interpreter has to be restarted two times in order to work fine for different users (cherry picked from commit 71bc759) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
prabhjyotsingh
pushed a commit
to prabhjyotsingh/zeppelin
that referenced
this pull request
Apr 29, 2019
…order to work fine for different users This PR fix the issue of scoped mode for new spark interpreter. It will only close SparkContext when there's no other live sessions. [Bug Fix] * [ ] - Task * https://issues.apache.org/jira/browse/ZEPPELIN-3749 * Unit test is added * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Jeff Zhang <zjffdu@apache.org> Closes apache#3166 from zjffdu/ZEPPELIN-3749 and squashes the following commits: 67ba556 [Jeff Zhang] ZEPPELIN-3749. New Spark interpreter has to be restarted two times in order to work fine for different users (cherry picked from commit 71bc759) Signed-off-by: Jeff Zhang <zjffdu@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR fix the issue of scoped mode for new spark interpreter. It will only close SparkContext when there's no other live sessions.
What type of PR is it?
[Bug Fix]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: