Copy-editing overview.md #3185
Closed
Copy-editing overview.md #3185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extensive grammar revisions for zeppelin/docs/usage/interpreter/overview.md
felixcheung
reviewed
Sep 23, 2018
docs/usage/interpreter/overview.md
Outdated
| So users needs to understand the ([interpreter mode setting ](../usage/interpreter/interpreter_bindings_mode.html) of Zeppelin and be aware when interpreter process is launched. E.g. If we set spark interpreter setting as isolated per note. Under this setting, each note will launch one interpreter process. | ||
| In this scenario, user need to put `ConfInterpreter` as the first paragraph as the below example. Otherwise the customized setting can not be applied (Actually it would report ERROR) | ||
| `ConfInterpreter` is a generic interpreter that can be used by any interpreter. The input format should be the property file format. | ||
| It can be used to make custom settings for any interpreter. However, it requires being run before the interpreter process is launched. When the interpreter process is launched is determined by the interpreter mode setting. |
There was a problem hiding this comment.
what is required to run in it requires being run before the interpreter?
docs/usage/interpreter/overview.md
Outdated
| Each Interpreter Setting can choose one of 'shared', 'scoped', 'isolated' interpreter binding mode. | ||
| In 'shared' mode, every notebook bound to the Interpreter Setting will share the single Interpreter instance. In 'scoped' mode, each notebook will create new Interpreter instance in the same interpreter process. In 'isolated' mode, each notebook will create new Interpreter process. | ||
| In the Interpreter Settings, one can choose one of the 'shared', 'scoped', or 'isolated' interpreter binding modes. | ||
| In 'shared' mode, every notebook bound to the Interpreter Setting will share a single Interpreter instance. In 'scoped' mode, each notebook will create new a interpreter instance in the same interpreter process. In 'isolated' mode, each notebook will create new a interpreter process. |
There was a problem hiding this comment.
create new a interpreter -> create a new interpreter
There was a problem hiding this comment.
Thanks for catching this.
docs/usage/interpreter/overview.md
Outdated
| ## What is interpreter setting? | ||
| Zeppelin interpreter setting is the configuration of a given interpreter on Zeppelin server. For example, the properties are required for hive JDBC interpreter to connect to the Hive server. | ||
| ## What are the interpreter settings? | ||
| The interpreter settings are the configuration of a given interpreter on the Zeppelin server. For example, certain properties need to be set for the Hive JDBC interpreter to connect to the Hive server. |
There was a problem hiding this comment.
minor: if this is the first mention of Hive in this doc, we should put Apache Hive
|
great, thx! |
|
LGTM |
|
this was merged? is github not syncing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extensive grammar revisions for zeppelin/docs/usage/interpreter/overview.md
What is this PR for?
The documentation at zeppelin/docs/usage/interpreter/overview.md contained numerous instances of bad grammar. This PR improves it.
What type of PR is it?
Documentation