docs [master]: REST API JSON response status fix #3224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolks
changed the title
jolks
changed the title
jolks
changed the title
|
Thanks @jolks for the contribution. |
Leemoonsoo
pushed a commit
to Leemoonsoo/zeppelin
that referenced
this pull request
Nov 18, 2018
### What is this PR for? Since v0.8.0, REST API JSON response `status` attribute has changed from `CREATED` to `OK`. Related source code: * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/rest/NotebookRestApi.java * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/main/java/org/apache/zeppelin/rest/InterpreterRestApi.java ### What type of PR is it? Documentation ### Questions: * Shall I add tests to check the returned `status` in: * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/InterpreterRestApiTest.java * https://github.com/apache/zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java Author: John Lau <jolks@outlook.com> Closes apache#3224 from jolks/doc_rest_api_fix and squashes the following commits: 9037b55 [John Lau] REST API JSON response status fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Since v0.8.0, REST API JSON response
statusattribute has changed fromCREATEDtoOK.Related source code:
What type of PR is it?
Documentation
Questions:
statusin: