Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZEPPELIN-3876. Unable to rename note #3234

Closed
wants to merge 1 commit into from
Closed

ZEPPELIN-3876. Unable to rename note #3234

wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Nov 22, 2018 •
edited

What is this PR for?

This is trivial PR for fixing the issue of unable to rename note. The root cause is that the notePath may have 2 leading / which cause the error.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

felixcheung
felixcheung reviewed Nov 25, 2018
View reviewed changes
Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add a test for this?

@zjffdu
Copy link
Contributor Author

zjffdu commented Dec 5, 2018

Test is added, will merge it no more comments

@asfgit asfgit closed this in a02e8e0 Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixcheung felixcheung felixcheung left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@zjffdu @felixcheung