[ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

[conker84]

What is this PR for?

Add the support for Point and Date data types introduced since Neo4j 3.4

What type of PR is it?

[Improvement] In order to allow users to use the Neo4j Interpreter with the last introduced Data types

Todos

• - Bumped Neo4j dependecies version
• - Added new data types to test

What is the Jira issue?

• Put link here, and add ZEPPELIN-3882

How should this be tested?

• Execute the unit tests

Screenshots (if appropriate)

Questions:

• Does the licenses files need update? no
• Is there breaking changes for older versions? no
• Does this needs documentation? no

[conker84]

@felixcheung I'm back.

[felixcheung]

looks like you are blocked by #3243

https://api.travis-ci.org/v3/job/461718800/log.txt

[conker84]

Can you give me a ping when it's ready?

[zjffdu]

@conker84 #3243 is fixed, could you rebase this PR ?

[conker84]

I did it, and travis it's green now:
https://travis-ci.org/conker84/zeppelin

[conker84]

@zjffdu ping

[conker84]

@zjffdu @felixcheung ping

[conker84]

Still no news?

[felixcheung]

I see it's green. not sure why the report above is not.

[felixcheung]

LGTM

[felixcheung]

merging if no more comment

[felixcheung]

it looks like the github rebase and merge option is picking the last commit description

[jongyoul]

@felixcheung I think it would be better to squash and merge with some edit of title indicating an issue number. WDYT?

[felixcheung]

Github doesn’t let me edit title. I think committer should use the merge script and not the github Web UI. If you think this is a problem, let me know

[jongyoul]

I've tested my wip pr by clicking squash and merge button on the pr page. I saw we could edit a title and commit messages as well. Could you please check it again?

[felixcheung]

Squash and merge seems like the right option,
https://help.github.com/articles/merging-a-pull-request/

[felixcheung]

@conker84 sorry, could you see if you could re open this PR so I can merge again?

[jongyoul]

@felixcheung Thanks a lot 👍

[felixcheung]

@conker84 ping - this was reverted, could you re-open

[conker84]

@felixcheung sorry I lost this, do you mean open a new issue? Because I cannot reopen this one

[felixcheung]

hm, this is a bit tricky - could you open a new branch and cherry-pick the commits to it, then open a new PR? @conker84

[conker84]

@felixcheung I created the #3284. Let me know if I have to do something else

[felixcheung]

thanks!