-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix beam-runners-flink and zeppelin-scio scala version to 2.10 #3258
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm, yes, but then building -Pscala-2.11 will provide scala-2.10 output? that's kinda weird.
you are right. it didn't make sense. the reason i did this is because i wanted the build to pass. i remove the beam interpreter afterwards as i dont need it. |
do you think it's a good idea to tamper with beam version in |
what about we don't build beam and scio if scala-2.11? |
also we could upgrade beam interpreter to "require" beam 2.3 also (so it does build with scala-2.11) |
that's what i did in: ffca03c do you have a better approach? |
ah, that would make different versions of beam with scala-2.10 or scala-2.11. is there a scio version that works with scala-2.11? what if we upgrade the supported version of beam and scio in all profile? |
we don't have much choice here. beam was never crossed built with scala. starting version 2.3.0 it is built with 2.11 only (prior versions with 2.10). |
in that case, can we make it build beam only when it has support for it. |
9f77401
to
0a10387
Compare
closing this for lack of time. i'll use this for my own testing: |
What is this PR for?
build is failing when trying to use scala-2.11 profile
What type of PR is it?
[Hot Fix]
Todos
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions: