IPythonInterpreter delete temp file and close stream #3287
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
felixcheung
reviewed
Jan 24, 2019
| return "grpcio is not installed"; | ||
| try (FileInputStream in = new FileInputStream(stderrFile)) { | ||
| return "Fail to run pip freeze.\n" + IOUtils.toString(in); | ||
| } |
There was a problem hiding this comment.
is it going to close FileInputStream when it is out of scope here?
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
delete temporary file and close inputstream in IPythonInterpreter.checkIPythonPrerequisite()
What type of PR is it?
[Bug Fix]
Todos
*no
What is the Jira issue?
How should this be tested?
Screenshots (if appropriate)
Questions:
no
no
no