Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4007]. Travis CI is broken for branch-0.8 #3309

Closed
wants to merge 1 commit into from

Conversation

zjffdu
Copy link
Contributor

@zjffdu zjffdu commented Feb 17, 2019

What is this PR for?

This PR fix several issues on branch-0.8 to make the CI pass.

  1. netty of python's grpc dependencies is conflicted with that of spark. This PR upgrade the grpc version of python interpreter.
  2. change paragraph running via z.runNote from blocking to non-blocking. Otherwise the paragraph output is missing (ZeppelinSparkClusterTest#zRunTest will fail).
  3. Separate each spark version integration into separate classes. Just like what we did in [ZEPPELIN-4001] zeppelin-interpreter-integration is ignored due to wrong folder structure #3306

What type of PR is it?

[Bug Fix | Refactoring]

Todos

  • - Task

What is the Jira issue?

How should this be tested?

  • CI pass

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

Copy link
Member

@felixcheung felixcheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, tbh, this looks like a fairly big change. could help to update the PR title about what's changed

@@ -56,7 +56,7 @@ public void setUp() {
}


@Test
// @Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug/JIRA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -480,7 +480,7 @@ public void testShowAndHideLineNumbers() throws Exception {
}
}

@Test
// @Test
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JIRA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asfgit pushed a commit that referenced this pull request Feb 28, 2019
### What is this PR for?

This PR fix several issues on branch-0.8 to make the CI pass.

1. netty of python's grpc dependencies is conflicted with that of spark. This PR upgrade the grpc version of python interpreter.
2. change paragraph running via z.runNote from blocking to non-blocking. Otherwise the paragraph output is missing (ZeppelinSparkClusterTest#zRunTest will fail).
3. Separate each spark version integration into separate classes. Just like what we did in #3306

### What type of PR is it?
[Bug Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://jira.apache.org/jira/browse/ZEPPELIN-4007

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes #3309 from zjffdu/ZEPPELIN-4007 and squashes the following commits:

2c9fbf4 [Jeff Zhang] [ZEPPELIN-4007]. Travis CI is broken for branch-0.8
@zjffdu zjffdu closed this Feb 28, 2019
prabhjyotsingh pushed a commit to prabhjyotsingh/zeppelin that referenced this pull request Jun 14, 2019
This PR fix several issues on branch-0.8 to make the CI pass.

1. netty of python's grpc dependencies is conflicted with that of spark. This PR upgrade the grpc version of python interpreter.
2. change paragraph running via z.runNote from blocking to non-blocking. Otherwise the paragraph output is missing (ZeppelinSparkClusterTest#zRunTest will fail).
3. Separate each spark version integration into separate classes. Just like what we did in apache#3306

[Bug Fix | Refactoring]

* [ ] - Task

* https://jira.apache.org/jira/browse/ZEPPELIN-4007

* CI pass

* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

Author: Jeff Zhang <zjffdu@apache.org>

Closes apache#3309 from zjffdu/ZEPPELIN-4007 and squashes the following commits:

2c9fbf4 [Jeff Zhang] [ZEPPELIN-4007]. Travis CI is broken for branch-0.8

Change-Id: I278670a33a6849b1a73849daab9d60b8066544d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants