Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4278]: Fixed closing bracket in bin/common.cmd #3433

Closed
wants to merge 1 commit into from

Conversation

msid
Copy link

@msid msid commented Aug 27, 2019

What is this PR for?

Fixed closing bracket in common.cmd file, that was causing error on running zeppelin in Windows environment

What type of PR is it?

Bug Fix

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4278

How should this be tested?

User should be able to run Zeppelin on Windows environment

Questions:

  • Does the licenses files need update?
    • No
  • Is there breaking changes for older versions?
    • No
  • Does this needs documentation?
    • No

@zjffdu
Copy link
Contributor

zjffdu commented Aug 28, 2019

LGTM

asfgit pushed a commit that referenced this pull request Aug 29, 2019
### What is this PR for?
Fixed closing bracket in common.cmd file, that was causing error on running zeppelin in Windows environment

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4278

### How should this be tested?
User should be able to run Zeppelin on Windows environment

### Questions:
* Does the licenses files need update?
  * No
* Is there breaking changes for older versions?
  * No
* Does this needs documentation?
  * No

Author: msid <mySIDis0x11@gmail.com>

Closes #3433 from msid/ZEPPELIN-4278 and squashes the following commits:

61338e6 [msid] [ZEPPELIN-4278]: Fixed closing bracket in bin/common.cmd
@zjffdu
Copy link
Contributor

zjffdu commented Aug 29, 2019

@msid I have merged it , could you close this PR ?

@msid msid closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants