Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4448] delete unused variable in ZeppelinServer.java #3522

Closed
wants to merge 1 commit into from

Conversation

iamabug
Copy link
Contributor

@iamabug iamabug commented Nov 15, 2019

What is this PR for?

delete an unused variable in ZeppelinServer.java

What type of PR is it?

Improvement

Todos

What is the Jira issue?

[ZEPPELIN-4448] https://issues.apache.org/jira/browse/ZEPPELIN-4448

How should this be tested?

Travis CI

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    no
  • Is there breaking changes for older versions?
    no
  • Does this needs documentation?
    no

@zjffdu
Copy link
Contributor

zjffdu commented Nov 16, 2019

@iamabug Could you update the PR description ?

@iamabug
Copy link
Contributor Author

iamabug commented Nov 16, 2019

@iamabug Could you update the PR description ?

Is it ok now ?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 16, 2019

Please add prefix [ZEPPELIN-XXXX] to the PR title

@iamabug iamabug changed the title delete unused variable in ZeppelinServer.java [ZEPPELIN-4448] delete unused variable in ZeppelinServer.java Nov 16, 2019
@iamabug
Copy link
Contributor Author

iamabug commented Nov 16, 2019

Please add prefix [ZEPPELIN-XXXX] to the PR title

Done.

@zjffdu
Copy link
Contributor

zjffdu commented Nov 16, 2019

Thanks @iamabug one last thing, could you paste your travis build link here ?

@iamabug
Copy link
Contributor Author

iamabug commented Nov 16, 2019

https://travis-ci.org/iamabug/zeppelin

Is this the right link ?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 16, 2019

That's right, thanks for the contribution @iamabug
The failed test is due hadoop-lzo issue which is being fixed in another PR. I will let you know when that PR is merged, then you can rebase your PR and trigger the CI again.

@iamabug
Copy link
Contributor Author

iamabug commented Nov 16, 2019

Sure. Thanks for your guidance.

@zjffdu
Copy link
Contributor

zjffdu commented Nov 19, 2019

@iamabug The hadoop lzo issue is fixed, could you do a rebase and trigger the travis CI again ?

@iamabug
Copy link
Contributor Author

iamabug commented Nov 20, 2019

@zjffdu Travis CI has run again but two of them failed, is there something wrong ?

@zjffdu
Copy link
Contributor

zjffdu commented Nov 20, 2019

These issues are being fixed somewhere else, will merge this PR if no more comments

@asfgit asfgit closed this in 9bdcae2 Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants