Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4583] Fix artifact resolving issues #3620

Closed

Conversation

rimolive
Copy link

What is this PR for?

Fixes the problem with install-interpreter script when it tries to resolve Maven artifacts in sonatype, in which only accepts https connections recently.

What type of PR is it?

Bug Fix

What is the Jira issue?

How should this be tested?

  • Build a zeppelin distribution with no interpreters installed
  • Run install-interpreter script to install any interpreter

@zjffdu
Copy link
Contributor

zjffdu commented Feb 1, 2020

Thanks for the fix @rimolive
I think the changes in zeppelin-web/package-lock.json is not necessary ?

@rimolive
Copy link
Author

rimolive commented Feb 3, 2020

Yes, I think. The code is a bit messed in my local repo, but I'll remove this file.

@gerlowskija
Copy link

Would love to see this get in. I work with a 3rd party interpreter for Solr called zeppelin-solr, and this bug blocks us from installing it anywhere. Been a big pain for our team.

Actually, now that I think of it, even when this gets merged we would have to drop a jar into our Zeppelin install or wait for a whole new release since the URL here is hardcoded in Java-land.

Do you guys know of any workaround in the interim?

@rimolive
Copy link
Author

rimolive commented Feb 6, 2020

@gerlowskija The only workaround I found is to apply these changes in a local repo and build zeppelin-interpreter code. Unfortunately, this change affect Java classes that must be compiled.

If you are using zeppelin 0.8.2, don't forget that conf/interpreter-list file must be changed to download and install 0.8.2 artifacts (currently it is downloading 0.8.0).

@zjffdu
Copy link
Contributor

zjffdu commented Feb 7, 2020

@rimolive No other changes besides .gitignore ?

@zjffdu
Copy link
Contributor

zjffdu commented Feb 21, 2020

ping @rimolive

@rimolive
Copy link
Author

I'm still looking at it. Something strange has happened.

@rimolive
Copy link
Author

@zjffdu I think someone already made the changes in Booter.java to use https, which makes this PR useless. I'm going to close it but looking forward for other ways to contribute with the project.

@rimolive rimolive closed this Feb 29, 2020
@rimolive rimolive deleted the rmartine-install-interpreter branch February 29, 2020 18:02
@zjffdu
Copy link
Contributor

zjffdu commented Feb 29, 2020

Thanks @rimolive for the investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants