Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZEPPELIN-4580] check the instance type rather than the class name #3647

Closed
wants to merge 1 commit into from
Closed

Conversation

jeff-hammel-leapyear
Copy link
Contributor

@jeff-hammel-leapyear jeff-hammel-leapyear commented Feb 14, 2020

What is this PR for?

A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html

This checks if the realm is an instance of KnoxJwtRealm instead of checking for it by name to enable subclassing of KnoxJwtRealm.

What type of PR is it?

[Bug Fix]

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-4580

How should this be tested?

CI run is at https://travis-ci.org/LeapYear/zeppelin-source/builds/650518752

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

@jeff-hammel-leapyear
Copy link
Contributor Author

This is a port of #3618 vs master instead of the 0.8 branch. I will post CI results and put up for review with Travis finishes

@jeff-hammel-leapyear
Copy link
Contributor Author

CI run is at https://travis-ci.org/LeapYear/zeppelin-source/builds/650518752

I tried to go through and figure out the failures. Those that I could seemed to be unrelated to my change. I also compared to the run for the previous commit on master: https://travis-ci.org/LeapYear/zeppelin-source/builds/650515988 . Both had errors, albeit not an identical set. The job output is large and on top of being hard to read doesn't fully load in my browser (Chrome). If there is anything specific I should look for, please point me to the right place.

@zjffdu
Copy link
Contributor

zjffdu commented Feb 15, 2020

Thanks @jeff-hammel-leapyear The failed test is unrelated. I will merge your PR soon if no more comment

@asfgit asfgit closed this in c4adf54 Feb 17, 2020
@jeff-hammel-leapyear jeff-hammel-leapyear deleted the jeff/ZEPPELIN-4580 branch February 18, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants